Bug 106895 - [chromium] move setMockDeviceOrientation to TestRunner library
Summary: [chromium] move setMockDeviceOrientation to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 05:53 PST by Dan Carney
Modified: 2013-01-16 05:52 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.78 KB, patch)
2013-01-15 05:53 PST, Dan Carney
no flags Details | Formatted Diff | Diff
Patch (10.07 KB, patch)
2013-01-16 02:08 PST, Dan Carney
no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2013-01-16 05:24 PST, Dan Carney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2013-01-15 05:53:14 PST
[chromium] move setMockDeviceOrientation to TestRunner library
Comment 1 Dan Carney 2013-01-15 05:53:53 PST
Created attachment 182745 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 05:55:39 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2013-01-15 06:03:28 PST
Comment on attachment 182745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182745&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:89
> +    virtual WebKit::WebDeviceOrientationClientMock* deviceOrientationClientMock() { return 0; }

content_shell doesn't have a mock, but a real client. I think instead of adding the mock to the delegate interface, we should add a setDeviceOrientation() callback.
Comment 4 Adam Barth 2013-01-15 11:35:15 PST
We've never really established a strong pattern for mocks for use in testing.  I wouldn't be surprised if you find a bunch of craziness here.
Comment 5 jochen 2013-01-15 11:38:50 PST
Actually, I'd like to avoid using mocks as much as possible, so we get more coverage of the content module
Comment 6 Adam Barth 2013-01-15 13:02:37 PST
Ok.  Presumably we'll need to mock at some level in order to test things like Geolocation, but feel free to rip out mocks whenever you like.  :)
Comment 7 Dan Carney 2013-01-16 02:08:11 PST
Created attachment 182938 [details]
Patch
Comment 8 Dan Carney 2013-01-16 05:24:11 PST
Created attachment 182966 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-16 05:51:57 PST
Comment on attachment 182966 [details]
Patch

Clearing flags on attachment: 182966

Committed r139875: <http://trac.webkit.org/changeset/139875>
Comment 10 WebKit Review Bot 2013-01-16 05:52:01 PST
All reviewed patches have been landed.  Closing bug.