RESOLVED FIXED 106895
[chromium] move setMockDeviceOrientation to TestRunner library 
https://bugs.webkit.org/show_bug.cgi?id=106895
Summary [chromium] move setMockDeviceOrientation to TestRunner library
Dan Carney
Reported 2013-01-15 05:53:14 PST
[chromium] move setMockDeviceOrientation to TestRunner library
Attachments
Patch (9.78 KB, patch)
2013-01-15 05:53 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2013-01-16 02:08 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2013-01-16 05:24 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2013-01-15 05:53:53 PST
Created attachment 182745 [details] Patch
WebKit Review Bot
Comment 2 2013-01-15 05:55:39 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 3 2013-01-15 06:03:28 PST
Comment on attachment 182745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182745&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:89 > + virtual WebKit::WebDeviceOrientationClientMock* deviceOrientationClientMock() { return 0; } content_shell doesn't have a mock, but a real client. I think instead of adding the mock to the delegate interface, we should add a setDeviceOrientation() callback.
Adam Barth
Comment 4 2013-01-15 11:35:15 PST
We've never really established a strong pattern for mocks for use in testing. I wouldn't be surprised if you find a bunch of craziness here.
jochen
Comment 5 2013-01-15 11:38:50 PST
Actually, I'd like to avoid using mocks as much as possible, so we get more coverage of the content module
Adam Barth
Comment 6 2013-01-15 13:02:37 PST
Ok. Presumably we'll need to mock at some level in order to test things like Geolocation, but feel free to rip out mocks whenever you like. :)
Dan Carney
Comment 7 2013-01-16 02:08:11 PST
Created attachment 182938 [details] Patch
Dan Carney
Comment 8 2013-01-16 05:24:11 PST
Created attachment 182966 [details] Patch
WebKit Review Bot
Comment 9 2013-01-16 05:51:57 PST
Comment on attachment 182966 [details] Patch Clearing flags on attachment: 182966 Committed r139875: <http://trac.webkit.org/changeset/139875>
WebKit Review Bot
Comment 10 2013-01-16 05:52:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.