RESOLVED FIXED 106893
Web Inspector: refactor DefaultTextEditor's paintLine method 
https://bugs.webkit.org/show_bug.cgi?id=106893
Summary Web Inspector: refactor DefaultTextEditor's paintLine method
Andrey Lushnikov
Reported 2013-01-15 05:20:59 PST
Refactor DefaultTextEditor's paintLine method: separate its range rendering functionality into a subroutine. It will be useful in future development.
Attachments
Patch (5.21 KB, patch)
2013-01-15 05:48 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.60 KB, patch)
2013-01-15 06:15 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-01-15 05:48:41 PST
Created attachment 182744 [details] Patch
Andrey Lushnikov
Comment 2 2013-01-15 06:15:34 PST
Created attachment 182750 [details] Patch
WebKit Review Bot
Comment 3 2013-01-15 07:51:38 PST
Comment on attachment 182750 [details] Patch Clearing flags on attachment: 182750 Committed r139740: <http://trac.webkit.org/changeset/139740>
WebKit Review Bot
Comment 4 2013-01-15 07:51:42 PST
All reviewed patches have been landed. Closing bug.
Vsevolod Vlasov
Comment 5 2013-01-15 08:03:18 PST
This patch made closure compiler fail. Source/WebCore/inspector/front-end/DefaultTextEditor.js:1893: WARNING - Property token never defined on {cssClass: string, endColumn: number, startColumn: number} var cssClass = ranges[i].token ? "webkit-" + ranges[i].token : "";
Note You need to log in before you can comment on or make changes to this bug.