Bug 106893 - Web Inspector: refactor DefaultTextEditor's paintLine method
Summary: Web Inspector: refactor DefaultTextEditor's paintLine method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 05:20 PST by Andrey Lushnikov
Modified: 2013-01-15 08:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2013-01-15 05:48 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2013-01-15 06:15 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-15 05:20:59 PST 
Refactor DefaultTextEditor's paintLine method: separate its range rendering functionality into a subroutine. It will be useful in future development.
Comment 1 Andrey Lushnikov 2013-01-15 05:48:41 PST 
Created attachment 182744 [details]
Patch
Comment 2 Andrey Lushnikov 2013-01-15 06:15:34 PST 
Created attachment 182750 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-15 07:51:38 PST 
Comment on attachment 182750 [details]
Patch

Clearing flags on attachment: 182750

Committed r139740: <http://trac.webkit.org/changeset/139740>
Comment 4 WebKit Review Bot 2013-01-15 07:51:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Vsevolod Vlasov 2013-01-15 08:03:18 PST 
This patch made closure compiler fail.

Source/WebCore/inspector/front-end/DefaultTextEditor.js:1893: WARNING - Property token never defined on {cssClass: string, endColumn: number, startColumn: number}
            var cssClass = ranges[i].token ? "webkit-" + ranges[i].token : "";