Bug 106879 – Group all request parameters which are used to match CSS Rules into a parameter object.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hayato Ito]

This is a separated patch from bug 82169.
This is a starting point to factor StyleResolver so we can implement the new features.

[Hayato Ito]

Created attachment 182717 [details]
factored. Introduces MatchRequest

[Dominic Cooney]

Comment on attachment 182717 [details]
factored. Introduces MatchRequest

View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review

> Source/WebCore/ChangeLog:3
> +        Group all request parameters which is used to match CSS Rules into a one parameter.

is used => are used

to agree with the plural parameters

Also

a one parameter => a parameter object

"a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"

[Dimitri Glazkov (Google)]

Comment on attachment 182717 [details]
factored. Introduces MatchRequest

Please address Dominic's nits.

[Hayato Ito]

Thank you for the review.
Let me land the patch afte fixing the ChangeLog.

(In reply to comment #2)
> (From update of attachment 182717 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Group all request parameters which is used to match CSS Rules into a one parameter.
> 
> is used => are used
> 
> to agree with the plural parameters
> 
> Also
> 
> a one parameter => a parameter object
> 
> "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"

[Hayato Ito]

Created attachment 182887 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182887 [details]
Patch for landing

Clearing flags on attachment: 182887

Committed r139817: <http://trac.webkit.org/changeset/139817>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.