Bug 106879 - Group all request parameters which are used to match CSS Rules into a parameter object.
Summary: Group all request parameters which are used to match CSS Rules into a paramet...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 89879 82169
  Show dependency treegraph
 
Reported: 2013-01-15 01:01 PST by Hayato Ito
Modified: 2013-01-15 18:07 PST (History)
8 users (show)

See Also:


Attachments
factored. Introduces MatchRequest (13.69 KB, patch)
2013-01-15 01:08 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
Patch for landing (13.70 KB, patch)
2013-01-15 17:47 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-01-15 01:01:07 PST
This is a separated patch from bug 82169.
This is a starting point to factor StyleResolver so we can implement the new features.
Comment 1 Hayato Ito 2013-01-15 01:08:15 PST
Created attachment 182717 [details]
factored. Introduces MatchRequest
Comment 2 Dominic Cooney 2013-01-15 06:31:14 PST
Comment on attachment 182717 [details]
factored. Introduces MatchRequest

View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review

> Source/WebCore/ChangeLog:3
> +        Group all request parameters which is used to match CSS Rules into a one parameter.

is used => are used

to agree with the plural parameters

Also

a one parameter => a parameter object

"a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"
Comment 3 Dimitri Glazkov (Google) 2013-01-15 09:09:30 PST
Comment on attachment 182717 [details]
factored. Introduces MatchRequest

Please address Dominic's nits.
Comment 4 Hayato Ito 2013-01-15 17:40:30 PST
Thank you for the review.
Let me land the patch afte fixing the ChangeLog.

(In reply to comment #2)
> (From update of attachment 182717 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Group all request parameters which is used to match CSS Rules into a one parameter.
> 
> is used => are used
> 
> to agree with the plural parameters
> 
> Also
> 
> a one parameter => a parameter object
> 
> "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"
Comment 5 Hayato Ito 2013-01-15 17:47:07 PST
Created attachment 182887 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-01-15 18:07:30 PST
Comment on attachment 182887 [details]
Patch for landing

Clearing flags on attachment: 182887

Committed r139817: <http://trac.webkit.org/changeset/139817>
Comment 7 WebKit Review Bot 2013-01-15 18:07:35 PST
All reviewed patches have been landed.  Closing bug.