WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106879
Group all request parameters which are used to match CSS Rules into a parameter object.
https://bugs.webkit.org/show_bug.cgi?id=106879
Summary
Group all request parameters which are used to match CSS Rules into a paramet...
Hayato Ito
Reported
2013-01-15 01:01:07 PST
This is a separated patch from
bug 82169
. This is a starting point to factor StyleResolver so we can implement the new features.
Attachments
factored. Introduces MatchRequest
(13.69 KB, patch)
2013-01-15 01:08 PST
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
Patch for landing
(13.70 KB, patch)
2013-01-15 17:47 PST
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Hayato Ito
Comment 1
2013-01-15 01:08:15 PST
Created
attachment 182717
[details]
factored. Introduces MatchRequest
Dominic Cooney
Comment 2
2013-01-15 06:31:14 PST
Comment on
attachment 182717
[details]
factored. Introduces MatchRequest View in context:
https://bugs.webkit.org/attachment.cgi?id=182717&action=review
> Source/WebCore/ChangeLog:3 > + Group all request parameters which is used to match CSS Rules into a one parameter.
is used => are used to agree with the plural parameters Also a one parameter => a parameter object "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"
Dimitri Glazkov (Google)
Comment 3
2013-01-15 09:09:30 PST
Comment on
attachment 182717
[details]
factored. Introduces MatchRequest Please address Dominic's nits.
Hayato Ito
Comment 4
2013-01-15 17:40:30 PST
Thank you for the review. Let me land the patch afte fixing the ChangeLog. (In reply to
comment #2
)
> (From update of
attachment 182717
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=182717&action=review
> > > Source/WebCore/ChangeLog:3 > > + Group all request parameters which is used to match CSS Rules into a one parameter. > > is used => are used > > to agree with the plural parameters > > Also > > a one parameter => a parameter object > > "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter"
Hayato Ito
Comment 5
2013-01-15 17:47:07 PST
Created
attachment 182887
[details]
Patch for landing
WebKit Review Bot
Comment 6
2013-01-15 18:07:30 PST
Comment on
attachment 182887
[details]
Patch for landing Clearing flags on attachment: 182887 Committed
r139817
: <
http://trac.webkit.org/changeset/139817
>
WebKit Review Bot
Comment 7
2013-01-15 18:07:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug