WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106872
Update GraphicsContext to support winding rule in clip operator for Chromium
https://bugs.webkit.org/show_bug.cgi?id=106872
Summary
Update GraphicsContext to support winding rule in clip operator for Chromium
Rik Cabanier
Reported
2013-01-14 22:10:44 PST
Add support for winding operator in chromium codebase
Attachments
Patch
(2.80 KB, text/plain)
2013-01-17 13:19 PST
,
Rik Cabanier
no flags
Details
Patch
(2.67 KB, patch)
2013-01-17 13:39 PST
,
Rik Cabanier
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Rik Cabanier
Comment 1
2013-01-17 13:19:57 PST
Created
attachment 183256
[details]
Patch
Justin Novosad
Comment 2
2013-01-17 13:33:10 PST
Comment on
attachment 183256
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=183256&action=review
> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361 > + storage.setFillType(ftype);
I think you mean to set the fill type back to savedFillRule here? We shouldn't even need to do that since storage is a temp copy, or am I missing something?
Rik Cabanier
Comment 3
2013-01-17 13:39:51 PST
Created
attachment 183262
[details]
Patch
Rik Cabanier
Comment 4
2013-01-17 13:40:58 PST
(In reply to
comment #2
)
> (From update of
attachment 183256
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=183256&action=review
> > > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361 > > + storage.setFillType(ftype); > > I think you mean to set the fill type back to savedFillRule here? We shouldn't even need to do that since storage is a temp copy, or am I missing something?
you're correct. I thought it was somehow set in the platform path. Fixed in latest patch (+ removed obsolete comment)
Philip Rogers
Comment 5
2013-01-17 19:25:45 PST
Comment on
attachment 183262
[details]
Patch This patch is straightforward and looks good to me.
Dirk Schulze
Comment 6
2013-01-17 19:30:34 PST
Comment on
attachment 183262
[details]
Patch Reviewed together with pdr. Looked good for us. r=me
WebKit Review Bot
Comment 7
2013-01-17 20:02:59 PST
Comment on
attachment 183262
[details]
Patch Clearing flags on attachment: 183262 Committed
r140098
: <
http://trac.webkit.org/changeset/140098
>
WebKit Review Bot
Comment 8
2013-01-17 20:03:04 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug