Bug 106864 - [EFL][WK2] Process single tap using mouse move, down and up event.
Summary: [EFL][WK2] Process single tap using mouse move, down and up event.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eunmi Lee
URL:
Keywords:
Depends on: 102643
Blocks: 111702
  Show dependency tree / graph
 
Reported: 2013-01-14 20:37 PST by Eunmi Lee
Modified: 2013-11-18 00:22 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.49 KB, patch)
2013-01-14 20:54 PST, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2013-01-15 02:19 PST, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (5.38 KB, patch)
2013-03-04 23:31 PST, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (17.03 KB, patch)
2013-03-05 21:28 PST, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (21.53 KB, patch)
2013-03-18 00:18 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (21.77 KB, patch)
2013-03-19 03:29 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (21.87 KB, patch)
2013-07-04 00:00 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (21.50 KB, patch)
2013-07-29 00:34 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (21.68 KB, patch)
2013-08-07 04:21 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (8.03 KB, patch)
2013-10-18 02:24 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2013-01-14 20:37:37 PST 
Process single tap gesture of WebKit2 EFL port using WebEvent::GestureSingleTap,
and enable GESTURE_EVENTS to use GestureSingleTap in the WebKit2 EFL if WEBKIT2 and TILED_BACKING_STORE are enabled.
Comment 1 Eunmi Lee 2013-01-14 20:54:16 PST 
Created attachment 182692 [details]
Patch
Comment 2 Eunmi Lee 2013-01-15 02:19:21 PST 
Created attachment 182724 [details]
Patch

Update patch for changed Bug 102643
Comment 3 Eunmi Lee 2013-03-04 23:31:47 PST 
Created attachment 191411 [details]
Patch

Rebased.
Comment 4 Eunmi Lee 2013-03-05 21:28:37 PST 
Created attachment 191646 [details]
Patch

Rebase and add WKViewSendGestureEvent().
Comment 5 Eunmi Lee 2013-03-18 00:18:56 PDT 
Created attachment 193495 [details]
Patch

Modified codes to use EFLGestureEvent.
Comment 6 Eunmi Lee 2013-03-19 03:29:08 PDT 
Created attachment 193775 [details]
Patch

Rebase and rename EFLGestureEvent to EwkGestureEvent.
Comment 7 Eunmi Lee 2013-07-04 00:00:04 PDT 
Created attachment 206055 [details]
Patch

Rebased.
Comment 8 Chris Dumez 2013-07-04 00:30:16 PDT 
(In reply to comment #7)
> Created an attachment (id=206055) [details]
> Patch
> 
> Rebased.

The patch does not apply.
Comment 9 Eunmi Lee 2013-07-29 00:34:57 PDT 
Created attachment 207625 [details]
Patch

Rebase.
Comment 10 Eunmi Lee 2013-08-07 04:21:46 PDT 
Created attachment 208250 [details]
Patch

Rebase.
Comment 11 Eunmi Lee 2013-10-16 23:09:34 PDT 
I will update patch because GESTURE_EVENTS will be removed.
Comment 12 Eunmi Lee 2013-10-18 02:24:37 PDT 
Created attachment 214552 [details]
Patch

Process single tap using mouse events instead of GestureSingleTap event.
Comment 13 Chris Dumez 2013-10-18 06:59:00 PDT 
Comment on attachment 214552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review

LGTM % the mouse move which seems a little bit odd. r=me.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142
> +    WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove);

So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough?
Comment 14 Eunmi Lee 2013-11-17 23:54:24 PST 
(In reply to comment #13)
> (From update of attachment 214552 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review
> 
> LGTM % the mouse move which seems a little bit odd. r=me.
> 
> > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142
> > +    WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove);
> 
> So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough?

Thanks for review! (I'm late)
MouseMoveEvent is needed to move the mouse pointer to the clicked location.
Comment 15 WebKit Commit Bot 2013-11-18 00:22:50 PST 
Comment on attachment 214552 [details]
Patch

Clearing flags on attachment: 214552

Committed r159401: <http://trac.webkit.org/changeset/159401>
Comment 16 WebKit Commit Bot 2013-11-18 00:22:54 PST 
All reviewed patches have been landed.  Closing bug.