Bug 106856 - Support variables inside -webkit-box-reflect CSS property.
Summary: Support variables inside -webkit-box-reflect CSS property.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-14 19:17 PST by Luke Macpherson
Modified: 2013-01-23 20:45 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.97 KB, patch)
2013-01-14 19:22 PST, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch (14.95 KB, patch)
2013-01-15 16:35 PST, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch for landing (15.01 KB, patch)
2013-01-23 19:13 PST, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2013-01-14 19:17:37 PST
Support variables inside -webkit-box-reflect CSS property.
Comment 1 Luke Macpherson 2013-01-14 19:22:15 PST
Created attachment 182683 [details]
Patch
Comment 2 Build Bot 2013-01-14 21:40:46 PST
Comment on attachment 182683 [details]
Patch

Attachment 182683 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15841798
Comment 3 Luke Macpherson 2013-01-15 16:35:04 PST
Created attachment 182872 [details]
Patch
Comment 4 Luke Macpherson 2013-01-23 15:01:47 PST
Can anyone review this?
Comment 5 Tony Chang 2013-01-23 15:48:48 PST
Comment on attachment 182872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182872&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:612
> +    default:
> +        ASSERT_NOT_REACHED();

Remove the default: case so the compiler will ensure we're testing all cases.

> Source/WebCore/css/CSSReflectValue.cpp:41
> +    if (m_mask)
> +        return m_direction->cssText() + ' ' + m_offset->cssText() + ' ' + m_mask->cssText();
> +    return m_direction->cssText() + ' ' + m_offset->cssText();

I would mention in the ChangeLog that you no longer use StringBuilder but this is just as fast because of StringOperators.h and StringConcatenate.h.

> Source/WebCore/css/CSSReflectValue.cpp:49
> +        return m_direction->customSerializeResolvingVariables(variables) + ' ' + m_offset->customSerializeResolvingVariables(variables) + ' ' + m_mask->serializeResolvingVariables(variables);
> +    return m_direction->customSerializeResolvingVariables(variables) + ' ' + m_offset->customSerializeResolvingVariables(variables);

You could mention this in the ChangeLog too.
Comment 6 Luke Macpherson 2013-01-23 19:13:48 PST
Created attachment 184380 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-01-23 20:45:39 PST
Comment on attachment 184380 [details]
Patch for landing

Clearing flags on attachment: 184380

Committed r140642: <http://trac.webkit.org/changeset/140642>
Comment 8 WebKit Review Bot 2013-01-23 20:45:44 PST
All reviewed patches have been landed.  Closing bug.