Bug 106853 – [Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Cooney]

See this test on the flakiness dashboard here: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-css-cue-lifetime.html>

This test is noted to be slow on other platforms, but it started timing out reliably on Chromium Win7 dbg in this range: <http://trac.webkit.org/log/?verbose=on&rev=139564&stop_rev=139562>

r139562 looks like a likely candidate.

[Dima Gorbik]

Created attachment 182678 [details]
Proposed fix 0.1

[Eric Carlson]

Comment on attachment 182678 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review

> LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20
>  RUN(video.currentTime = 1.8000000000000003)

This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like:

run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10))

[Dima Gorbik]

Created attachment 182681 [details]
Proposed fix 0.2

[Dima Gorbik]

(In reply to comment #2)
> (From update of attachment 182678 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review
> 
> > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20
> >  RUN(video.currentTime = 1.8000000000000003)
> 
> This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like:
> 
> run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10))

I have though about this. I think this should be dependent only on JSC code. But still it could be good to have rounded values.

[Dominic Cooney]

Comment on attachment 182681 [details]
Proposed fix 0.2

I am not a reviewer, but this looks good to me.

[WebKit Review Bot]

Comment on attachment 182681 [details]
Proposed fix 0.2

Clearing flags on attachment: 182681

Committed r139737: <http://trac.webkit.org/changeset/139737>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/13017237>