Bug 106853 - [Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
Summary: [Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Dima Gorbik
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-14 18:31 PST by Dominic Cooney
Modified: 2013-01-15 10:58 PST (History)
6 users (show)

See Also:


Attachments
Proposed fix 0.1 (7.36 KB, patch)
2013-01-14 18:49 PST, Dima Gorbik
no flags Details | Formatted Diff | Diff
Proposed fix 0.2 (7.79 KB, patch)
2013-01-14 19:16 PST, Dima Gorbik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2013-01-14 18:31:10 PST
See this test on the flakiness dashboard here: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-css-cue-lifetime.html>

This test is noted to be slow on other platforms, but it started timing out reliably on Chromium Win7 dbg in this range: <http://trac.webkit.org/log/?verbose=on&rev=139564&stop_rev=139562>

r139562 looks like a likely candidate.
Comment 1 Dima Gorbik 2013-01-14 18:49:16 PST
Created attachment 182678 [details]
Proposed fix 0.1
Comment 2 Eric Carlson 2013-01-14 19:06:25 PST
Comment on attachment 182678 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review

> LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20
>  RUN(video.currentTime = 1.8000000000000003)

This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like:

run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10))
Comment 3 Dima Gorbik 2013-01-14 19:16:25 PST
Created attachment 182681 [details]
Proposed fix 0.2
Comment 4 Dima Gorbik 2013-01-14 19:18:51 PST
(In reply to comment #2)
> (From update of attachment 182678 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review
> 
> > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20
> >  RUN(video.currentTime = 1.8000000000000003)
> 
> This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like:
> 
> run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10))

I have though about this. I think this should be dependent only on JSC code. But still it could be good to have rounded values.
Comment 5 Dominic Cooney 2013-01-14 22:31:22 PST
Comment on attachment 182681 [details]
Proposed fix 0.2

I am not a reviewer, but this looks good to me.
Comment 6 WebKit Review Bot 2013-01-15 07:13:37 PST
Comment on attachment 182681 [details]
Proposed fix 0.2

Clearing flags on attachment: 182681

Committed r139737: <http://trac.webkit.org/changeset/139737>
Comment 7 WebKit Review Bot 2013-01-15 07:13:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2013-01-15 10:58:50 PST
<rdar://problem/13017237>