Bug 106843 - [Sub pixel layout] RTL cells with padding wraps
Summary: [Sub pixel layout] RTL cells with padding wraps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-14 16:44 PST by Emil A Eklund
Modified: 2013-01-15 16:16 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2013-01-14 16:47 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (4.33 KB, patch)
2013-01-15 15:11 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2013-01-14 16:44:14 PST 
At certain zoom levels table cells with padding wraps for rtl content.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=141035
Comment 1 Emil A Eklund 2013-01-14 16:47:39 PST 
Created attachment 182661 [details]
Patch
Comment 2 Levi Weintraub 2013-01-15 14:59:59 PST 
Comment on attachment 182661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182661&action=review

> Source/WebCore/rendering/RenderTable.h:198
> +    virtual LayoutUnit paddingEnd() const OVERRIDE { return static_cast<int>(RenderBlock::paddingEnd()); }
> +    virtual LayoutUnit paddingStart() const OVERRIDE { return static_cast<int>(RenderBlock::paddingStart()); }

Please add a one-liner comment explaining why this is done.
Comment 3 Emil A Eklund 2013-01-15 15:11:53 PST 
Created attachment 182853 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-01-15 16:16:21 PST 
Comment on attachment 182853 [details]
Patch for landing

Clearing flags on attachment: 182853

Committed r139807: <http://trac.webkit.org/changeset/139807>
Comment 5 WebKit Review Bot 2013-01-15 16:16:25 PST 
All reviewed patches have been landed.  Closing bug.