Bug 106831 - [Chromium] Move BlobRegistryProxy into WebCore
Summary: [Chromium] Move BlobRegistryProxy into WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Blocks: 106829
  Show dependency treegraph
Reported: 2013-01-14 14:46 PST by Mark Pilgrim (Google)
Modified: 2013-01-14 19:49 PST (History)
5 users (show)

See Also:

Patch (14.79 KB, patch)
2013-01-14 14:47 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2013-01-14 14:46:37 PST
[Chromium] Move BlobRegistryProxy into WebCore
Comment 1 Mark Pilgrim (Google) 2013-01-14 14:47:20 PST
Created attachment 182631 [details]
Comment 2 Adam Barth 2013-01-14 17:35:40 PST
Comment on attachment 182631 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=182631&action=review

I think this is fine for a first patch.  There's more cleanup we can do to better integrate BlobRegistryProxy with BlobRegistryImpl

> Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:48
> +// We are part of the WebKit implementation.
> +using namespace WebKit;

As in the other patch, it would be better to remove this using directive and be explicit about when we're using things in the WebKit namespace.

> Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:52
> +BlobRegistry& blobRegistry()

It looks like this function is declared in Source/WebCore/platform/network/BlobRegistry.h.  I wonder if we should put this function in Source/WebCore/platform/network/BlobRegistryImpl.cpp?
Comment 3 WebKit Review Bot 2013-01-14 17:59:33 PST
Comment on attachment 182631 [details]

Clearing flags on attachment: 182631

Committed r139698: <http://trac.webkit.org/changeset/139698>
Comment 4 WebKit Review Bot 2013-01-14 17:59:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Mark Pilgrim (Google) 2013-01-14 19:49:09 PST
Filed Bug 106859 for WebKit prefix.