RESOLVED FIXED 106831
[Chromium] Move BlobRegistryProxy into WebCore 
https://bugs.webkit.org/show_bug.cgi?id=106831
Summary [Chromium] Move BlobRegistryProxy into WebCore
Mark Pilgrim (Google)
Reported 2013-01-14 14:46:37 PST
[Chromium] Move BlobRegistryProxy into WebCore
Attachments
Patch (14.79 KB, patch)
2013-01-14 14:47 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-01-14 14:47:20 PST
Created attachment 182631 [details] Patch
Adam Barth
Comment 2 2013-01-14 17:35:40 PST
Comment on attachment 182631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182631&action=review I think this is fine for a first patch. There's more cleanup we can do to better integrate BlobRegistryProxy with BlobRegistryImpl > Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:48 > +// We are part of the WebKit implementation. > +using namespace WebKit; As in the other patch, it would be better to remove this using directive and be explicit about when we're using things in the WebKit namespace. > Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:52 > +BlobRegistry& blobRegistry() It looks like this function is declared in Source/WebCore/platform/network/BlobRegistry.h. I wonder if we should put this function in Source/WebCore/platform/network/BlobRegistryImpl.cpp?
WebKit Review Bot
Comment 3 2013-01-14 17:59:33 PST
Comment on attachment 182631 [details] Patch Clearing flags on attachment: 182631 Committed r139698: <http://trac.webkit.org/changeset/139698>
WebKit Review Bot
Comment 4 2013-01-14 17:59:36 PST
All reviewed patches have been landed. Closing bug.
Mark Pilgrim (Google)
Comment 5 2013-01-14 19:49:09 PST
Filed Bug 106859 for WebKit prefix.
Note You need to log in before you can comment on or make changes to this bug.