Bug 106821 – [WK2] REGRESSION(r138301): NetworkProcess scheduler never resumes resource loads that were postponed due to connection limit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

There is an uninitialized variable, and if it happens to be non-0, loading works badly.

[Alexey Proskuryakov]

Created attachment 182618 [details]
proposed fix

[Brady Eidson]

Comment on attachment 182618 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=182618&action=review

> Source/WebKit2/ChangeLog:4
> +        NetworkProcess scheduler never resumes resource loads that were postponed
> +        due to connection limit

suspendPendingRequests count actually has nothing to do with the per-host limit.  May as well just say something like "Completely remove the concept of suspending requests from the network process"

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/139655>.

[Alexey Proskuryakov]

<rdar://problem/13010102>

[Alexey Proskuryakov]

> > Source/WebKit2/ChangeLog:4
> > +        NetworkProcess scheduler never resumes resource loads that were postponed
> > +        due to connection limit
> 
> suspendPendingRequests count actually has nothing to do with the per-host limit.  May as well just say something like "Completely remove the concept of suspending requests from the network process"

The reason why this is related to per-host limit is that only requests that were delayed (due to the limit or to other reasons) were then checked against m_suspendPendingRequestsCount.