Created attachment 182614 [details] Enables css3-text feature flag There has been some time that the mac buildbot fails to compile with the following message when css3-text is enabled [1]: In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/css/BasicShapeFunctions.cpp:35: /Volumes/Data/EWS/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2325:10: error: use of undeclared identifier 'CSSValueWavy' case CSSValueWavy: ^ 1 error generated. The attached patch reproduces the problem. The patch just enables css3-text and adds no new code. All other buildbots compile as expected so this problem seems specific to mac buildbot. I do not own a mac machine to fix this problem myself so I need help here. Landing css3 related patches without passing through the mac buildbot is not a good thing, I would like to have this problem fixed since the number of css3 related patches is growing. [1] https://bugs.webkit.org/show_bug.cgi?id=94094#c9 and https://bugs.webkit.org/show_bug.cgi?id=94094#c12
Comment on attachment 182614 [details] Enables css3-text feature flag Attachment 182614 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15867604
Comment on attachment 182614 [details] Enables css3-text feature flag Attachment 182614 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15841673 New failing tests: fast/css3-text/css3-text-decoration/text-decoration-style.html fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html
Comment on attachment 182614 [details] Enables css3-text feature flag View in context: https://bugs.webkit.org/attachment.cgi?id=182614&action=review > Source/WebKit/chromium/features.gypi:43 > - 'ENABLE_CSS3_CONDITIONAL_RULES=0', > - 'ENABLE_CSS3_TEXT=0', > + 'ENABLE_CSS3_CONDITIONAL_RULES=1', > + 'ENABLE_CSS3_TEXT=1', Why are you enabling this on Chromium?
Comment on attachment 182614 [details] Enables css3-text feature flag Attachment 182614 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15867721
(In reply to comment #3) > (From update of attachment 182614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182614&action=review > > > Source/WebKit/chromium/features.gypi:43 > > - 'ENABLE_CSS3_CONDITIONAL_RULES=0', > > - 'ENABLE_CSS3_TEXT=0', > > + 'ENABLE_CSS3_CONDITIONAL_RULES=1', > > + 'ENABLE_CSS3_TEXT=1', > > Why are you enabling this on Chromium? As I explained in the bug description several patches depends on being css3-text enabled to be tested by the bots: https://bugs.webkit.org/showdependencytree.cgi?id=58491&hide_resolved=1 I need to enable css3-text so that the bots can compile and test the patches above. Without such a change the bots disable all code that depends on css3-text, nothing is tested and the bot set a green for the patch even though nothing has been tested, so it can be false positive. The two failing unit tests for chromium buildbot is probably due to the change to LayoutTests/platform/chromium/TestExpectations. One of the links I wrote in the bug description talks about that. However, this bug report is about the mac buildbot, it does not compile even when no new code is added. I do not know why that happens and I cannot fix it because I do not own a mac machine to test it.
Great, it looks like the win buildbot has the same problem too.
(In reply to comment #3) > (From update of attachment 182614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182614&action=review > > > Source/WebKit/chromium/features.gypi:43 > > - 'ENABLE_CSS3_CONDITIONAL_RULES=0', > > - 'ENABLE_CSS3_TEXT=0', > > + 'ENABLE_CSS3_CONDITIONAL_RULES=1', > > + 'ENABLE_CSS3_TEXT=1', > > Why are you enabling this on Chromium? We are using this 'EWS-only' patch as a way to test the features we're implementing for CSS3 Text Decoration on the EWS bots, which are only compiled and tested when the 'CSS3_TEXT' feature flag is enabled. This was discussed with Julien Chaffraix a few months ago as a solution to test the code (provide two patches, one with the changes we intend to commit, and other with this patch merged just for EWS run, see bug 91638, 93507, 94094 and others for details).
Created attachment 183801 [details] Enables css3-text feature flag New version to force mac buildbot to update a couple .in files, now it compiles. Win buildbot still fails to compile.
Comment on attachment 183801 [details] Enables css3-text feature flag Attachment 183801 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16033185
Comment on attachment 183801 [details] Enables css3-text feature flag Attachment 183801 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16039116
Comment on attachment 183801 [details] Enables css3-text feature flag Attachment 183801 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16038122
Created attachment 183840 [details] Enables css3-text feature flag Touch the source of two auto-generated files to force them to be processed during incremental build.
Comment on attachment 183840 [details] Enables css3-text feature flag Attachment 183840 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16039236
Created attachment 184995 [details] Enables css3-text feature flag Touch Source/WebCore/css/CSSSupportsRule.idl to make win buildbot generate CSSSupportsRule during incremental build.
Comment on attachment 184995 [details] Enables css3-text feature flag Attachment 184995 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16158645
Comment on attachment 184995 [details] Enables css3-text feature flag Clearing review flag on this patch, since it's rather old at this point. Is this bug actually still valid, or can we close it out?
(In reply to comment #16) > (From update of attachment 184995 [details]) > Clearing review flag on this patch, since it's rather old at this point. > > Is this bug actually still valid, or can we close it out? Shorter answer: it is probably still valid. Longer answer: I use Linux only and do not have a mac or windows with Webkit installed to debug the problem myself. All changes in patch "Enables css3-text feature flag" were made to make my patches to do not fail with mac and win build bots. All that during several try and error rounds. The point is that css3-text is disabled by default in the build bots, which means that any patch that uses css3-text is approved by the bots, be they working or not. We (my ex-co-worker and me) did this to force the build bots to really test our patches instead of just approving them right away, which is the correct thing to do in our opinion. Without such a patch the bots are useless to catch possible regressions in css3-text code. PS: this patch is not meant to enter Webkit (at least not until css3-text is enabled by default).