Bug 106816 - Switch AudioDestinationChromium over to new createAudioDevice() method
Summary: Switch AudioDestinationChromium over to new createAudioDevice() method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-14 12:31 PST by Chris Rogers
Modified: 2013-01-16 19:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2013-01-14 12:33 PST, Chris Rogers
jamesr: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2013-01-14 12:31:20 PST
Switch AudioDestinationChromium over to new createAudioDevice() method
Comment 1 Chris Rogers 2013-01-14 12:33:08 PST
Created attachment 182612 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-14 14:44:06 PST
Comment on attachment 182612 [details]
Patch

Rejecting attachment 182612 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t-commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/src/AudioDestinationChromium.cpp
Hunk #1 FAILED at 66.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/AudioDestinationChromium.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'James Robinson']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15853704
Comment 3 Chris Rogers 2013-01-14 15:52:17 PST
Committed r139678: <http://trac.webkit.org/changeset/139678>
Comment 5 Chris Rogers 2013-01-16 19:10:33 PST
Committed r139951: <http://trac.webkit.org/changeset/139951>