Bug 106816 – Switch AudioDestinationChromium over to new createAudioDevice() method

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

Switch AudioDestinationChromium over to new createAudioDevice() method

[Chris Rogers]

Created attachment 182612 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182612 [details]
Patch

Rejecting attachment 182612 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t-commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/src/AudioDestinationChromium.cpp
Hunk #1 FAILED at 66.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/AudioDestinationChromium.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'James Robinson']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15853704

[Chris Rogers]

Committed r139678: <http://trac.webkit.org/changeset/139678>

[Levi Weintraub]

Reverted in r139695. Triggered a bunch of WebAudio crashes: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=webaudio%2Faudiochannelmerger-basic.html%2Cwebaudio%2Fbiquad-getFrequencyResponse.html%2Cwebaudio%2Faudiobuffersource-channels.html%2Cwebaudio%2Fdynamicscompressor-basic.html%2Cwebaudio%2Fmediaelementaudiosourcenode.html%2Cwebaudio%2Fpannernode-basic.html%2Cwebaudio%2Fbiquadfilternode-basic.html%2Cwebaudio%2Fconvolver-setBuffer-null.html%2Cwebaudio%2Faudionode.html%2Cwebaudio%2Fmediastreamaudiosourcenode.html

[Chris Rogers]

Committed r139951: <http://trac.webkit.org/changeset/139951>