RESOLVED FIXED 106807
[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
https://bugs.webkit.org/show_bug.cgi?id=106807
Summary [REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
Yury Semikhatsky
Reported 2013-01-14 10:34:05 PST
Upstreaming Chromium bug report http://code.google.com/p/chromium/issues/detail?id=167952 : Version 26.0.1373.0 canary OS: OSX 10.8.2, Windows 7 What steps will reproduce the problem? 1. Have a page with a Web Worker 2. Open dev tools, select Sources -> Workers -> click the worker 3. The Developer Tools popup will have all its sizing information set to 0 and appear in the top left corner really small 4. Resize the popup, resize all the sidebars [5. Close the popup and reopen via the Workers pane - it will have been reset to the top left corner] What is the expected output? What do you see instead? The window opens at a reasonable size the first time and upon repeated openings remembers its size.
Attachments
Patch (3.44 KB, patch)
2013-01-14 10:35 PST, Yury Semikhatsky
pfeldman: review+
Yury Semikhatsky
Comment 1 2013-01-14 10:35:51 PST
Pavel Feldman
Comment 2 2013-01-14 11:36:17 PST
Comment on attachment 182600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182600&action=review > Source/WebCore/inspector/front-end/WorkerManager.js:177 > + var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height); Why doesn't platform manage the preferred size?
WebKit Review Bot
Comment 3 2013-01-14 11:45:21 PST
Comment on attachment 182600 [details] Patch Clearing flags on attachment: 182600 Committed r139634: <http://trac.webkit.org/changeset/139634>
WebKit Review Bot
Comment 4 2013-01-14 11:45:25 PST
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 5 2013-01-15 01:00:37 PST
(In reply to comment #2) > (From update of attachment 182600 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182600&action=review > > > Source/WebCore/inspector/front-end/WorkerManager.js:177 > > + var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height); > > Why doesn't platform manage the preferred size? It provides something like 100x100 by default which is too small for inspector.
Note You need to log in before you can comment on or make changes to this bug.