Bug 106803 - [Chromium] Move AudioDestinationChromium into WebCore
Summary: [Chromium] Move AudioDestinationChromium into WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Blocks: 106829
  Show dependency treegraph
Reported: 2013-01-14 09:51 PST by Mark Pilgrim (Google)
Modified: 2013-01-14 14:45 PST (History)
7 users (show)

See Also:

Patch (23.32 KB, patch)
2013-01-14 09:52 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (23.27 KB, patch)
2013-01-14 12:28 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2013-01-14 09:51:14 PST
[Chromium] Move AudioDestinationChromium into WebCore
Comment 1 Mark Pilgrim (Google) 2013-01-14 09:52:51 PST
Created attachment 182594 [details]
Comment 2 Adam Barth 2013-01-14 10:12:59 PST
Comment on attachment 182594 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=182594&action=review

> Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:31

We usually put a blank line after this line.

> Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:38
> +using namespace WebKit;

Can we skip this using directive?  In WebCore, it's nice to be able to see what's used from the API.

> Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:45
> +// Size of the FIFO

There are lots of style errors in this file, but I guess I won't point them out since you're just moving this code.

> Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h:39
> +namespace WebKit { class WebAudioDevice; }

You probably don't need to forward declare this class given that you #include public/WebAudioDevice.h
Comment 3 Mark Pilgrim (Google) 2013-01-14 12:28:35 PST
Created attachment 182610 [details]
Comment 4 Mark Pilgrim (Google) 2013-01-14 12:29:08 PST
Comment on attachment 182610 [details]

Nits addressed.
Comment 5 WebKit Review Bot 2013-01-14 13:23:04 PST
Comment on attachment 182610 [details]

Clearing flags on attachment: 182610

Committed r139652: <http://trac.webkit.org/changeset/139652>
Comment 6 WebKit Review Bot 2013-01-14 13:23:08 PST
All reviewed patches have been landed.  Closing bug.