[Chromium] Move AudioDestinationChromium into WebCore
Created attachment 182594 [details] Patch
Comment on attachment 182594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182594&action=review > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:31 > +#if ENABLE(WEB_AUDIO) We usually put a blank line after this line. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:38 > +using namespace WebKit; Can we skip this using directive? In WebCore, it's nice to be able to see what's used from the API. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:45 > +// Size of the FIFO There are lots of style errors in this file, but I guess I won't point them out since you're just moving this code. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h:39 > +namespace WebKit { class WebAudioDevice; } You probably don't need to forward declare this class given that you #include public/WebAudioDevice.h
Created attachment 182610 [details] Patch
Comment on attachment 182610 [details] Patch Nits addressed.
Comment on attachment 182610 [details] Patch Clearing flags on attachment: 182610 Committed r139652: <http://trac.webkit.org/changeset/139652>
All reviewed patches have been landed. Closing bug.