Bug 106801 – Web Inspector: highlight regexp API for DefaultTextEditor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Lushnikov]

Add a highlight regexp API for TextEditor and DefaultTextEditor. This API should provide with the following capabilities:
- highlight all occurrences of regexp in text with some css class
- remove highlight for given regexp

[Andrey Lushnikov]

Created attachment 182592 [details]
Patch

[Andrey Lushnikov]

Created attachment 182593 [details]
Patch

[Pavel Feldman]

Comment on attachment 182593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182593&action=review

Please rename Regexp into Regex in method names.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:116
> +    highlightRegexp: function(regexp, cssClass)

highlightRegex

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1961
> +                offsetTop: spans[i].offsetTop,

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1963
> +                offsetHeight: spans[i].offsetHeight

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1980
> +            highlight.style.marginTop = (metrics[i].offsetTop - highlight.offsetTop) + "px";

nuke

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2054
> +                if (!this._highlightRegexps.hasOwnProperty(key))

This is always false.

[Andrey Lushnikov]

Created attachment 182725 [details]
Patch

[Build Bot]

Comment on attachment 182725 [details]
Patch

Attachment 182725 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15845891

New failing tests:
inspector/editor/highlighter-basics.html
inspector/editor/text-editor-highlight-regexp.html
inspector/editor/highlighter-paste-in-comment.html

[WebKit Review Bot]

Comment on attachment 182725 [details]
Patch

Attachment 182725 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15860912

New failing tests:
inspector/editor/highlighter-basics.html
inspector/editor/highlighter-paste-in-comment.html

[Andrey Lushnikov]

Created attachment 182752 [details]
Patch

[Pavel Feldman]

Comment on attachment 182752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182752&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1977
> +        var extraWidth = 1;

const

[WebKit Review Bot]

Comment on attachment 182752 [details]
Patch

Rejecting attachment 182752 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ore/inspector/front-end/TextEditor.js
patching file Source/WebCore/inspector/front-end/textEditor.css
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt
patching file LayoutTests/inspector/editor/text-editor-highlight-regexp.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15884591

[Andrey Lushnikov]

Created attachment 182927 [details]
Patch

[Pavel Feldman]

Comment on attachment 182927 [details]
Patch

Clearing flags on attachment: 182927

Committed r139844: <http://trac.webkit.org/changeset/139844>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.

[Andrey Lushnikov]

Reopening to attach new patch.

[Andrey Lushnikov]

Created attachment 182945 [details]
Patch

[Andrey Lushnikov]

Attached patch to a wrong bug.