Bug 106781 - MediaStream API: Update MediaStreamTrack::readyState to match specification
Summary: MediaStream API: Update MediaStreamTrack::readyState to match specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords: WebExposed
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2013-01-14 05:03 PST by Tommy Widenflycht
Modified: 2013-01-16 01:35 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.91 KB, patch)
2013-01-14 06:13 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2013-01-15 06:40 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2013-01-14 05:03:59 PST 
readyState is now a string and no longer an integer.
Comment 1 Tommy Widenflycht 2013-01-14 06:13:09 PST 
Created attachment 182563 [details]
Patch
Comment 2 Tommy Widenflycht 2013-01-14 06:14:34 PST 
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
Comment 3 Adam Barth 2013-01-14 09:24:04 PST 
Comment on attachment 182563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182563&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:125
> +

You've got an extra blank line here.
Comment 4 WebKit Review Bot 2013-01-14 09:30:21 PST 
Comment on attachment 182563 [details]
Patch

Clearing flags on attachment: 182563

Committed r139618: <http://trac.webkit.org/changeset/139618>
Comment 5 WebKit Review Bot 2013-01-14 09:30:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Levi Weintraub 2013-01-14 17:38:37 PST 
Speculatively rolled out in r139696. It appeared to be causing crashes in Debug bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fregions%2Fautoheight-allregions-nobreaks.html

If the crashes continue, I'll roll this back in tomorrow.
Comment 7 Tommy Widenflycht 2013-01-15 02:08:07 PST 
Wrong patch but right patch author... The culprit is https://bugs.webkit.org/show_bug.cgi?id=106660. Found and fixed the real problem.
Comment 8 Tommy Widenflycht 2013-01-15 02:26:58 PST 
https://bugs.webkit.org/show_bug.cgi?id=106886
Comment 9 Tommy Widenflycht 2013-01-15 06:40:45 PST 
Created attachment 182756 [details]
Patch
Comment 10 Tommy Widenflycht 2013-01-15 06:41:49 PST 
Taking the opportunity to address Adams comment about an extra line.
Comment 11 Levi Weintraub 2013-01-15 11:08:46 PST 
Thanks for getting to the bottom of this!
Comment 12 Kentaro Hara 2013-01-16 01:31:22 PST 
Comment on attachment 182756 [details]
Patch

Looks OK
Comment 13 WebKit Review Bot 2013-01-16 01:35:54 PST 
Comment on attachment 182756 [details]
Patch

Clearing flags on attachment: 182756

Committed r139849: <http://trac.webkit.org/changeset/139849>
Comment 14 WebKit Review Bot 2013-01-16 01:35:58 PST 
All reviewed patches have been landed.  Closing bug.