Bug 106775 – [GTK] Fix baseline positioning issue by updating Freetype

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Dominik Röttsches (drott)]

Analogously to bug 106774, I'd recommend updating freetype from 2.4.2 in jhbuild to > 2.4.6, ideally 2.4.11.

[Zan Dobersek]

Since mimicking bug #106774 seems to be desired, is enabling subpixel layout required along with updating Freetype?

[Zan Dobersek]

(Enabling subpixel layout on GTK is covered by bug #94792.)

[Dominik Röttsches (drott)]

(In reply to comment #1)
> Since mimicking bug #106774 seems to be desired, is enabling subpixel layout required along with updating Freetype?

It's not required, but in my opinion it makes sense to do the rebaselining for both changes in one effort. 
That said, I would recommend to wait until Freetype's next release. I am expecting http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=e0469372be3870a5ad60b2c4586e9c281357bd28
to have a (positive) effect on baseline positioning. The commit fixes a rounding issue for smaller font sizes by emulating what Windows GDI is doing.

[Zan Dobersek]

Created attachment 198187 [details]
Patch

[Zan Dobersek]

(In reply to comment #4)
> Created an attachment (id=198187) [details]
> Patch

This bumps the Freetype dependency to 2.4.11. All the rebaselining will be at first done in a GitHub branch and possibly landed over a low-traffic period (probably in weekend time).

The e0469372be patch (comment #3) is at the moment not included but will be tested on the branch to see if the reduction in required rebaselining is worth including the patch separately and applying it over 2.4.11 or if it is better to wait for the 2.4.12 release.

[Zan Dobersek]

Created attachment 198821 [details]
Patch

[Zan Dobersek]

(In reply to comment #6)
> Created an attachment (id=198821) [details]
> Patch

Now includes the e0469372be Freetype patch. That patch doesn't really reduce the amount of baselines, but still needs an enormous amount of rebaselining if applying it on a rebaselined subpixel-enabled setup, so I'd like to include this patch before Freetype 2.4.12 is released.

[Zan Dobersek]

Comment on attachment 198821 [details]
Patch

Clearing flags on attachment: 198821

Committed r148794: <http://trac.webkit.org/changeset/148794>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.