Bug 106769 – [GTK] build-webkit fails if the jhbuild wrapper is not used

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sergio Villar Senin]

[GTK] build-webkit fails if the jhbuild wrapper is not used

[Sergio Villar Senin]

Created attachment 182529 [details]
Patch

[Sergio Villar Senin]

I found this while trying to use WEBKITOUTPUTDIR. The jhbuild wrapper was not used because I didn't have the "Dependencies" folder in the new location specified by the environmnet variable.

[kov's GTK+ EWS bot]

Comment on attachment 182529 [details]
Patch

Attachment 182529 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15868440

[Sergio Villar Senin]

Created attachment 182551 [details]
Patch

[Sergio Villar Senin]

Created attachment 182555 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 182555 [details]
Patch

Attachment 182555 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15868501

[Sergio Villar Senin]

(In reply to comment #6)
> (From update of attachment 182555 [details])
> Attachment 182555 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/15868501

Beh, not sure where that "3" comes from...

[Martin Robinson]

Comment on attachment 182555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182555&action=review

The build failure seems legitimate, so it should probably be fixed.

> Tools/Scripts/webkitdirs.pm:1967
> +    # Prefix the command with jhbuild run.
> +    my $jhbuildWrapper = jhbuildWrapperPrefixIfNeeded();
> +    unshift(@buildArgs, $jhbuildWrapper) if ($jhbuildWrapper ne "");
> +

Why not add a function like prefixWithJHBuildWrapperIfNeeded()?

[Sergio Villar Senin]

Created attachment 182729 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 182729 [details]
Patch

Clearing flags on attachment: 182729

Committed r139868: <http://trac.webkit.org/changeset/139868>

[Sergio Villar Senin]

All reviewed patches have been landed.  Closing bug.