Bug 106738 – Double clicking to select word at the start of a line should not selects line number

• Status: NEW
• Component: Tools / Tests

[Joseph Pecoraro]

This bugs me occasionally when I'm trying to review a patch and select some text to search the patch for it.

* STEPS TO REPRODUCE
1. Open a PFR, for example <https://bugs.webkit.org/attachment.cgi?id=99713&action=review>
2. Double click to select some text at the start of a line, like "WebInspector.CompilerSourceMapping".
  => The line number is also selected, so "32WebInspector.CompilerSourceMapping" is the selected text.

* NOTES:
This appears to be because there is no space / break between the <span> containing the line number and the <span> text intended to be select:

>    <div class="Line LineContainer add" id="line220">
>        <span class="from lineNumber">&nbsp;</span><span class="to lineNumber">32</span><span class="text">WebInspector.CompilerSourceMapping = function()</span>
>    </div>

We should just add something there to break selection between the two spans.

[Joseph Pecoraro]

I can't find a CSS property that separates selection between two inline spans:

    <span>left</span><span>right</span>

But using a 0-width space &#8203; works. I could update PrettyPatch output to include that in <span class="to linenumber"> or between that span and <span class="text">. I'll play around with different solutions.

[Joseph Pecoraro]

Maybe just putting a space in the HTML will be better then a 0-width space. That might make actual multiple-line selection better anyways.

[Ahmad Saleem]

This is something really good idea and it is still an issue. Although, Webkit is shifting to GitHub for review etc. but if it is something important, should we implement it or mark it as WONTFIX?