RESOLVED FIXED 106737
Make ninja the default build system for build-webkit --chromium on mac 
https://bugs.webkit.org/show_bug.cgi?id=106737
Summary Make ninja the default build system for build-webkit --chromium on mac
Nico Weber
Reported 2013-01-12 23:50:52 PST
Like bug 104434, but for chromium/mac.
Attachments
Patch (1.04 KB, patch)
2013-01-13 10:36 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (28 bytes, patch)
2013-01-21 13:15 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.05 KB, patch)
2013-01-21 13:27 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2013-01-12 23:53:50 PST
As it turns out, my attempt to make nrwt find the right binary automatically in http://trac.webkit.org/changeset/138294 wasn't quite right: it looks in Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (good) and Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (bad, should look in out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree instead). Since NRWT is so lasagna-code-y, it's not obvious how to fix that. I'll look at it some.
Nico Weber
Comment 2 2013-01-12 23:57:55 PST
Hey, I think my patch in bug 105597 probably addresses that. I should land it.
Nico Weber
Comment 3 2013-01-13 10:08:59 PST
Looks like this works now, at least with a standalone webkit build.
Nico Weber
Comment 4 2013-01-13 10:22:08 PST
With a standalone build, layout_tests/port/chromium.py's _static_build_path looks in these places: /Users/thakis/src/WebKit/Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree This includes the two right locations, so things work. In a webkit-in-chromium build, it looks in /Users/thakis/src/chrome/src/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/third_party/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/third_party/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree This is _almost_ right, but it doesn't look in third_party/WebKit/Source/WebKit/chromium/xcodebuild. However, that's already the case in trunk and nobody's complaining, so I guess nobody is doing webkit-in-chromium builds _and_ builds with xcodebuild and build-webkit.
Nico Weber
Comment 5 2013-01-13 10:35:07 PST
Filed bug 106745 for the problem in comment 4.
Nico Weber
Comment 6 2013-01-13 10:36:59 PST
Created attachment 182487 [details] Patch
Nico Weber
Comment 7 2013-01-13 10:37:39 PST
I think this should work, but let's wait with landing this until next weekend, to see if there are any problems with the ninja transition on linux.
Eric Seidel (no email)
Comment 8 2013-01-14 13:44:53 PST
Comment on attachment 182487 [details] Patch I wish to buy this product and or service. I might have written this as ! win however.
WebKit Review Bot
Comment 9 2013-01-19 14:45:50 PST
Comment on attachment 182487 [details] Patch Clearing flags on attachment: 182487 Committed r140260: <http://trac.webkit.org/changeset/140260>
WebKit Review Bot
Comment 10 2013-01-19 14:45:54 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2013-01-19 17:26:51 PST
Re-opened since this is blocked by bug 107387
Nico Weber
Comment 12 2013-01-19 20:52:16 PST
This is blocked on https://code.google.com/p/chromium/issues/detail?id=171146
Nico Weber
Comment 13 2013-01-21 13:09:42 PST
The hyphen stuff should now work. Let's try this again.
WebKit Review Bot
Comment 14 2013-01-21 13:13:00 PST
Comment on attachment 182487 [details] Patch Rejecting attachment 182487 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16039187
Nico Weber
Comment 15 2013-01-21 13:15:53 PST
Created attachment 183825 [details] Patch for landing
Nico Weber
Comment 16 2013-01-21 13:18:16 PST
Comment on attachment 183825 [details] Patch for landing I fail at webkit-patch
Nico Weber
Comment 17 2013-01-21 13:27:53 PST
Created attachment 183827 [details] Patch for landing
WebKit Review Bot
Comment 18 2013-01-21 14:05:46 PST
Comment on attachment 183827 [details] Patch for landing Clearing flags on attachment: 183827 Committed r140360: <http://trac.webkit.org/changeset/140360>
WebKit Review Bot
Comment 19 2013-01-21 14:05:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.