BlockingResourceMap has a single ThreadCondition, and wakes up all waiting loader threads. This does not have to be so inefficient. <rdar://problem/12886430>
Created attachment 182437 [details] proposed patch
Comment on attachment 182437 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=182437&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:190 > - if (!send(Messages::WebResourceLoader::WillSendRequest(requestID, request, redirectResponse))) { > + if (!sendSync(Messages::WebResourceLoader::WillSendRequest(request, redirectResponse), Messages::WebResourceLoader::WillSendRequest::Reply(request))) If the premise is that it's okay to make this a sync message because it's *always* on a background thread, please ASSERT to that effect. > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:288 > - if (!send(Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace(requestID, protectionSpace))) > + bool result; > + if (!sendSync(Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace(protectionSpace), Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace::Reply(result))) If the premise is that it's okay to make this a sync message because it's *always* on a background thread, please ASSERT to that effect.
Good point. Committed <http://trac.webkit.org/r139516>.