RESOLVED FIXED 106698
Builder should not be a valid parameter for stats dashboard 
https://bugs.webkit.org/show_bug.cgi?id=106698
Summary Builder should not be a valid parameter for stats dashboard
Julie Parent
Reported 2013-01-11 14:01:55 PST
This dashboard displays results for all builders, so builder is not a valid parameter here, as it is for other dashboards. Aka, loading http://test-results.appspot.com/dashboards/aggregate_results.html#builder=WebKit%20Win7 should at least print a warning about invalid parameter.
Attachments
Patch (2.99 KB, patch)
2013-01-11 14:27 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.99 KB, patch)
2013-01-11 15:26 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-01-11 14:27:30 PST
Created attachment 182418 [details] Patch
Dirk Pranke
Comment 2 2013-01-11 14:57:18 PST
Comment on attachment 182418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182418&action=review > Tools/ChangeLog:12 > + Note that the FIXME in dashboard_base about this was acutally wrong - nit: "actually".
Julie Parent
Comment 3 2013-01-11 15:26:52 PST
Created attachment 182432 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-11 16:43:12 PST
Comment on attachment 182432 [details] Patch for landing Clearing flags on attachment: 182432 Committed r139522: <http://trac.webkit.org/changeset/139522>
WebKit Review Bot
Comment 5 2013-01-11 16:43:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.