Bug 106694 - Move constructTreeFromHTMLToken into HTMLDocumentParser
Summary: Move constructTreeFromHTMLToken into HTMLDocumentParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-11 13:20 PST by Tony Gentilcore
Modified: 2013-01-11 17:30 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.35 KB, patch)
2013-01-11 13:21 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (7.47 KB, patch)
2013-01-11 13:34 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-11 13:20:54 PST
Move constructTreeFromHTMLToken into HTMLDocumentParser
Comment 1 Tony Gentilcore 2013-01-11 13:21:41 PST
Created attachment 182403 [details]
Patch
Comment 2 Adam Barth 2013-01-11 13:26:42 PST
Comment on attachment 182403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review

> Source/WebCore/html/parser/HTMLTreeBuilder.h:81
>      void constructTreeFromAtomicToken(AtomicHTMLToken*);

I would probably rename this function to "constructTree" now that we only have one.  :)
Comment 3 Tony Gentilcore 2013-01-11 13:34:41 PST
Created attachment 182408 [details]
Patch
Comment 4 Tony Gentilcore 2013-01-11 13:35:17 PST
(In reply to comment #2)
> (From update of attachment 182403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review
> 
> > Source/WebCore/html/parser/HTMLTreeBuilder.h:81
> >      void constructTreeFromAtomicToken(AtomicHTMLToken*);
> 
> I would probably rename this function to "constructTree" now that we only have one.  :)

Good catch. Done.
Comment 5 WebKit Review Bot 2013-01-11 17:30:04 PST
Comment on attachment 182408 [details]
Patch

Clearing flags on attachment: 182408

Committed r139523: <http://trac.webkit.org/changeset/139523>
Comment 6 WebKit Review Bot 2013-01-11 17:30:08 PST
All reviewed patches have been landed.  Closing bug.