WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106684
RenderScrollbarPart::computePreferredLogicalWidths is dead code
https://bugs.webkit.org/show_bug.cgi?id=106684
Summary
RenderScrollbarPart::computePreferredLogicalWidths is dead code
Ojan Vafai
Reported
2013-01-11 11:48:31 PST
RenderScrollbarPart::computePreferredLogicalWidths is dead code
Attachments
Patch
(2.43 KB, patch)
2013-01-11 11:50 PST
,
Ojan Vafai
darin
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2013-01-11 11:50:11 PST
Created
attachment 182388
[details]
Patch
Darin Adler
Comment 2
2013-01-11 12:07:21 PST
Comment on
attachment 182388
[details]
Patch OK
WebKit Review Bot
Comment 3
2013-01-11 14:52:09 PST
Comment on
attachment 182388
[details]
Patch
Attachment 182388
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/15829027
New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Ahmad Saleem
Comment 4
2022-09-10 16:06:37 PDT
This code is still present:
https://github.com/WebKit/WebKit/blob/628269ab7bc7e6fb74252ac05f78f95d1624f4bf/Source/WebCore/rendering/RenderScrollbarPart.cpp#L118
and
https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/rendering/RenderScrollbarPart.h#L63
This commit removed this test as well:
https://github.com/WebKit/WebKit/commit/b0d8e5e666d7635e9430fa130d04c0accf67d87f
I can try to land this once again and raise PR, if it is not reused code now? Thanks!
Ahmad Saleem
Comment 5
2022-09-10 16:18:29 PDT
Trying again -
https://github.com/WebKit/WebKit/pull/4229
EWS
Comment 6
2022-09-12 18:03:08 PDT
Committed
254417@main
(28ebb9bd0c1e): <
https://commits.webkit.org/254417@main
> Reviewed commits have been landed. Closing PR #4229 and removing active labels.
Radar WebKit Bug Importer
Comment 7
2022-09-12 18:04:19 PDT
<
rdar://problem/99847592
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug