Bug 106671 - [Qt] Use the shared HistoryItem serialization for QWebHistory
Summary: [Qt] Use the shared HistoryItem serialization for QWebHistory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on: 104525
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-11 09:36 PST by Jocelyn Turcotte
Modified: 2013-01-16 07:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (24.96 KB, patch)
2013-01-11 09:46 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (25.48 KB, patch)
2013-01-14 03:19 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (25.58 KB, patch)
2013-01-16 06:26 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-01-11 09:36:57 PST 
[Qt] Fix QWebHistory serialization of same-document navigations
Comment 1 Jocelyn Turcotte 2013-01-11 09:46:18 PST 
Created attachment 182355 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-01-14 03:19:04 PST 
Created attachment 182539 [details]
Patch

Make sure that the history is cleared when an HistoryItem internal version change as well instead of risking half-restoring the history.
Comment 3 Jocelyn Turcotte 2013-01-16 06:26:09 PST 
Created attachment 182972 [details]
Patch

Added a comment to explain the purpose of the commented out code, re-uploading also to run the EWS.
Comment 4 WebKit Review Bot 2013-01-16 07:08:15 PST 
Comment on attachment 182972 [details]
Patch

Clearing flags on attachment: 182972

Committed r139878: <http://trac.webkit.org/changeset/139878>
Comment 5 WebKit Review Bot 2013-01-16 07:08:18 PST 
All reviewed patches have been landed.  Closing bug.