Bug 106669 - [Qt] Switch to GStreamer 1.0
Summary: [Qt] Switch to GStreamer 1.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 106085 (view as bug list)
Depends on: 106085
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-11 08:51 PST by Sebastian Dröge (slomo)
Modified: 2013-09-05 07:14 PDT (History)
21 users (show)

See Also:


Attachments
Switch QtWebKit to GStreamer 1.0 (3.41 KB, patch)
2013-01-11 08:53 PST, Sebastian Dröge (slomo)
ossy: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2013-02-27 07:55 PST, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2013-01-11 08:51:56 PST
+++ This bug was initially created as a clone of Bug #106085 +++
Comment 1 Sebastian Dröge (slomo) 2013-01-11 08:53:57 PST
Created attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0
Comment 2 WebKit Review Bot 2013-01-11 08:57:15 PST
Attachment 182351 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2013-01-11 09:08:33 PST
Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review

> Source/WebCore/WebCore.pri:169
> +    DEFINES += GST_API_VERSION=1.0

That one is not needed I think.
Comment 4 Build Bot 2013-01-11 10:23:26 PST
Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

Attachment 182351 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15809385

New failing tests:
svg/as-image/img-preserveAspectRatio-support-2.html
Comment 5 Csaba Osztrogonác 2013-01-14 05:00:01 PST
Why we need one more bug report for this bug?
Comment 6 Csaba Osztrogonác 2013-02-05 07:22:36 PST
Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review

r=me with minor changes mentioned inline, but we should wait with landing until bots upgrade.

>> Source/WebCore/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

>> Source/WebCore/WebCore.pri:169
>> +    DEFINES += GST_API_VERSION=1.0
> 
> That one is not needed I think.

I agree, we don't need it.

>> Tools/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.
Comment 7 Csaba Osztrogonác 2013-02-05 07:23:45 PST
*** Bug 106085 has been marked as a duplicate of this bug. ***
Comment 8 Philippe Normand 2013-02-05 09:10:28 PST
The code changed a bit since this patch was uploaded, a rebase will be needed I'm afraid.
Comment 9 Csaba Osztrogonác 2013-02-05 09:11:12 PST
(In reply to comment #8)
> The code changed a bit since this patch was uploaded, a rebase will be needed I'm afraid.

It applied and worked for me as is. ;)
Comment 10 Philippe Normand 2013-02-05 09:26:03 PST
Oh right, sorry I was confusing myself with Bug 106085 :)
Comment 11 Allan Sandfeld Jensen 2013-02-27 07:55:16 PST
Created attachment 190523 [details]
Patch

Updated version of Sebastian's patch, but including temporary support for gstreamer 0.10.
Comment 12 Csaba Osztrogonác 2013-02-27 08:01:29 PST
Comment on attachment 190523 [details]
Patch

LGTM, r=me. We can remove the temporary support later.

One little nit: Shouldn't we warn the developers if they still use 0.1 to 
install 1.0 as soon as possible, because 0.1 support will be dropped soon?
Comment 13 Early Warning System Bot 2013-02-27 08:03:11 PST
Comment on attachment 190523 [details]
Patch

Attachment 190523 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16768710
Comment 14 Csaba Osztrogonác 2013-02-27 08:04:18 PST
(In reply to comment #13)
> (From update of attachment 190523 [details])
> Attachment 190523 [details] did not pass qt-ews (qt):
> Output: http://webkit-commit-queue.appspot.com/results/16768710

Hmmm ... is it possible if it is an incremental build issue?
Comment 15 Early Warning System Bot 2013-02-27 08:07:39 PST
Comment on attachment 190523 [details]
Patch

Attachment 190523 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16666128
Comment 16 Csaba Osztrogonác 2013-02-27 08:10:18 PST
Ádám or Zoltán, could you test it with clean build on a machine with Gstreamer 1.0?
Comment 17 Allan Sandfeld Jensen 2013-02-27 10:03:27 PST
(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 190523 [details] [details])
> > Attachment 190523 [details] [details] did not pass qt-ews (qt):
> > Output: http://webkit-commit-queue.appspot.com/results/16768710
> 
> Hmmm ... is it possible if it is an incremental build issue?

Yes, it doesn't build incrementally when upgrading from 0.1 to 1.0. The problem is the flags are same since use_gstreamer now implies 1.0
Comment 18 Csaba Osztrogonác 2013-02-27 10:07:26 PST
Yes, it is incremental build issue, Zoltán checked it.

Unfortunately "maybe clean build needed" feature in webkitdris.pm isn't
perfect for EWS bots. But it will work on the buildbots, so it's safe
to land it now.
Comment 19 WebKit Review Bot 2013-02-27 10:20:08 PST
Comment on attachment 190523 [details]
Patch

Clearing flags on attachment: 190523

Committed r144208: <http://trac.webkit.org/changeset/144208>
Comment 20 Philippe Normand 2013-09-05 06:55:50 PDT
Can this bug be closed now?
Comment 21 Csaba Osztrogonác 2013-09-05 07:14:55 PDT
(In reply to comment #20)
> Can this bug be closed now?

Yes.