RESOLVED FIXED Bug 106654
[chromium] move inspector related methods to TestRunner library 
https://bugs.webkit.org/show_bug.cgi?id=106654
Summary [chromium] move inspector related methods to TestRunner library
jochen
Reported 2013-01-11 04:20:14 PST
[chromium] move inspector related methods to TestRunner library
Attachments
Patch (11.45 KB, patch)
2013-01-11 04:20 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.30 KB, patch)
2013-01-11 12:12 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-11 04:20:35 PST
Created attachment 182318 [details] Patch
WebKit Review Bot
Comment 2 2013-01-11 04:23:21 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kentaro Hara
Comment 3 2013-01-11 04:23:41 PST
Comment on attachment 182318 [details] Patch ok
jochen
Comment 4 2013-01-11 04:26:02 PST
Comment on attachment 182318 [details] Patch setting to back to r? to wait for an API review
Adam Barth
Comment 5 2013-01-11 10:17:54 PST
Comment on attachment 182318 [details] Patch LGTM2
WebKit Review Bot
Comment 6 2013-01-11 11:08:17 PST
Comment on attachment 182318 [details] Patch Rejecting attachment 182318 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ls/DumpRenderTree/chromium/TestRunner/src/TestRunner.h Hunk #1 succeeded at 289 (offset 8 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Hunk #1 FAILED at 150. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/WebViewHost.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15811385
jochen
Comment 7 2013-01-11 12:12:49 PST
Created attachment 182389 [details] Patch for landing
WebKit Review Bot
Comment 8 2013-01-11 13:22:47 PST
Comment on attachment 182389 [details] Patch for landing Rejecting attachment 182389 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15815286
WebKit Review Bot
Comment 9 2013-01-12 05:58:52 PST
Comment on attachment 182389 [details] Patch for landing Clearing flags on attachment: 182389 Committed r139549: <http://trac.webkit.org/changeset/139549>
WebKit Review Bot
Comment 10 2013-01-12 05:58:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.