Bug 106649 - Simplify CSSSelectorList creation/adoption.
Summary: Simplify CSSSelectorList creation/adoption.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-11 03:00 PST by Andreas Kling
Modified: 2013-05-03 12:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (6.87 KB, patch)
2013-01-11 03:04 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-01-11 03:00:59 PST
CSSSelectorList has a mysterious separate construction path for lists with a single entry. Let's unify the paths.
Comment 1 Andreas Kling 2013-01-11 03:04:30 PST
Created attachment 182309 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-11 03:07:04 PST
Attachment 182309 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSSelectorList.cpp:70:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-05-03 12:10:36 PDT
Committed r149528: <http://trac.webkit.org/changeset/149528>