Bug 106640 - Web Inspector: [Canvas] introduce CallArgument type into the protocol
Summary: Web Inspector: [Canvas] introduce CallArgument type into the protocol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-11 00:59 PST by Andrey Adaikin
Modified: 2013-01-15 01:48 PST (History)
11 users (show)

See Also:


Attachments
Patch (24.71 KB, patch)
2013-01-11 01:03 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (27.88 KB, patch)
2013-01-11 03:07 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-01-11 00:59:24 PST
CallArgument type abstraction to describe arguments of a canvas context call.
Drive-by: Introduce a CanvasContext to fix the wrong contextId value in the protocol. The contextId should point to the Resource that represents a context (2D or 3D canvas)

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-11 01:03:54 PST
Created attachment 182287 [details]
Patch
Comment 2 Build Bot 2013-01-11 02:38:47 PST
Comment on attachment 182287 [details]
Patch

Attachment 182287 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15809246

New failing tests:
inspector/profiler/webgl/webgl-profiler-get-error.html
Comment 3 Andrey Adaikin 2013-01-11 03:07:39 PST
Created attachment 182311 [details]
Patch
Comment 4 Yury Semikhatsky 2013-01-15 01:17:08 PST
Comment on attachment 182311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182311&action=review

The patch mixes several unrelated changes which can be done in a separate CLs and would simplify the review process.

> Source/WebCore/inspector/Inspector.json:3210
> +                    { "name": "arguments", "type": "array", "items": { "$ref": "CallArgument" }, "optional": true },

Would be nice to have descriptions for the properties.
Comment 5 Andrey Adaikin 2013-01-15 01:25:34 PST
(In reply to comment #4)
> (From update of attachment 182311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182311&action=review
> 
> The patch mixes several unrelated changes which can be done in a separate CLs and would simplify the review process.
> 
> > Source/WebCore/inspector/Inspector.json:3210
> > +                    { "name": "arguments", "type": "array", "items": { "$ref": "CallArgument" }, "optional": true },
> 
> Would be nice to have descriptions for the properties.

Yeah, I intentionally kept this whole protocol hidden and undocumented while it's in a development state. I'd rather leave this as is and focus on other stuff for now, but if you insist, I'll add documentation in separate patch.
Comment 6 WebKit Review Bot 2013-01-15 01:47:56 PST
Comment on attachment 182311 [details]
Patch

Clearing flags on attachment: 182311

Committed r139729: <http://trac.webkit.org/changeset/139729>
Comment 7 WebKit Review Bot 2013-01-15 01:48:00 PST
All reviewed patches have been landed.  Closing bug.