Provide the ability to blur the snapshot of the plugin behind any label we want to display. This would allow a transparent label that is more readable.
<rdar://problem/12994916>
Created attachment 182250 [details] WIP Patch
Created attachment 182655 [details] Patch
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review > Source/WebCore/ChangeLog:13 > + slightly blur the snapshot behind the label so that it is more clear. All the code > + here is platform-neutral, but the treatment is specific to Mac. Unfortunately I > + couldn't find a better place to put the code (RenderThemeMac depends on a bunch > + of Objective C classes). The good news is that this operation is probably > + helpful to other ports, which would be a case of simply removing the #if PLATFORM. I don't think you need to make excuses for this being here. > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:228 > + RefPtr<RenderSnapshottedPlugInBlurFilter> blurFilter = RenderSnapshottedPlugInBlurFilter::create(5); Please move the '5' into a named constant.
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69 > + virtual FloatRect sourceImageRect() const { return m_sourceImageRect; } OVERRIDE keyword? > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:70 > + virtual FloatRect filterRegion() const { return m_filterRegion; } OVERRIDE keyword?
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review >> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69 >> + virtual FloatRect sourceImageRect() const { return m_sourceImageRect; } > > OVERRIDE keyword? No need in this case - the parent is pure virtual here.
Committed r139701: <http://trac.webkit.org/changeset/139701>