Bug 106630 - Blur the label background of a snapshotted plugin
Summary: Blur the label background of a snapshotted plugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-10 20:15 PST by Dean Jackson
Modified: 2013-01-14 19:51 PST (History)
7 users (show)

See Also:


Attachments
WIP Patch (5.07 KB, patch)
2013-01-10 20:26 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2013-01-14 16:27 PST, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-01-10 20:15:28 PST
Provide the ability to blur the snapshot of the plugin behind any label we want to display. This would allow a transparent label that is more readable.
Comment 1 Radar WebKit Bug Importer 2013-01-10 20:16:01 PST
<rdar://problem/12994916>
Comment 2 Dean Jackson 2013-01-10 20:26:54 PST
Created attachment 182250 [details]
WIP Patch
Comment 3 Dean Jackson 2013-01-14 16:27:50 PST
Created attachment 182655 [details]
Patch
Comment 4 Simon Fraser (smfr) 2013-01-14 16:50:34 PST
Comment on attachment 182655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review

> Source/WebCore/ChangeLog:13
> +        slightly blur the snapshot behind the label so that it is more clear. All the code
> +        here is platform-neutral, but the treatment is specific to Mac. Unfortunately I
> +        couldn't find a better place to put the code (RenderThemeMac depends on a bunch
> +        of Objective C classes). The good news is that this operation is probably
> +        helpful to other ports, which would be a case of simply removing the #if PLATFORM.

I don't think you need to make excuses for this being here.

> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:228
> +    RefPtr<RenderSnapshottedPlugInBlurFilter> blurFilter = RenderSnapshottedPlugInBlurFilter::create(5);

Please move the '5' into a named constant.
Comment 5 Jon Lee 2013-01-14 16:51:58 PST
Comment on attachment 182655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review

> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69
> +    virtual FloatRect sourceImageRect() const { return m_sourceImageRect; }

OVERRIDE keyword?

> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:70
> +    virtual FloatRect filterRegion() const { return m_filterRegion; }

OVERRIDE keyword?
Comment 6 Dean Jackson 2013-01-14 17:06:20 PST
Comment on attachment 182655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review

>> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69
>> +    virtual FloatRect sourceImageRect() const { return m_sourceImageRect; }
> 
> OVERRIDE keyword?

No need in this case - the parent is pure virtual here.
Comment 7 Dean Jackson 2013-01-14 19:51:58 PST
Committed r139701: <http://trac.webkit.org/changeset/139701>