RFC 2616 says: Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header field is defined as a comma-separated list [i.e., #(values)]. It MUST be possible to combine the multiple header fields into one "field-name: field-value" pair, without changing the semantics of the message, by appending each subsequent field-value to the first, each separated by a comma. The order in which header fields with the same field-name are received is therefore significant to the interpretation of the combined field value, and thus a proxy MUST NOT change the order of these field values when a message is forwarded.
Created attachment 182244 [details] Patch
Created attachment 182286 [details] Patch
Comment on attachment 182286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182286&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:69 > +static bool isAppendableHeader(String key) More efficient to use const String & here.
(In reply to comment #3) > (From update of attachment 182286 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182286&action=review > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:69 > > +static bool isAppendableHeader(String key) > > More efficient to use const String & here. nice catch, thanks
Created attachment 182303 [details] Patch
Comment on attachment 182303 [details] Patch LGTM.
Comment on attachment 182303 [details] Patch Clearing flags on attachment: 182303 Committed r139423: <http://trac.webkit.org/changeset/139423>
All reviewed patches have been landed. Closing bug.