Bug 106619 - Plugin snapshot label should take device resolution and inset into account
Summary: Plugin snapshot label should take device resolution and inset into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-10 17:01 PST by Dean Jackson
Modified: 2013-01-10 18:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2013-01-10 17:05 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-01-10 17:01:18 PST 
The label image we draw for snapshotted plugins needs to be aware of device resolution. It also needs to take the inset of the image into account (say it has a drop shadow).
Comment 1 Dean Jackson 2013-01-10 17:02:03 PST 
<rdar://problem/12878149>
Comment 2 Dean Jackson 2013-01-10 17:05:03 PST 
Created attachment 182227 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-10 17:08:14 PST 
Attachment 182227 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:184:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:185:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:186:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2013-01-10 17:37:40 PST 
Comment on attachment 182227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182227&action=review

> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:46
> +static const int startLabelInset = 20; // But the label is inset from its box also. FIXME: This will be removed when we go to a ShadowDOM approach.

That type of comment isn't very future-proof!
Comment 5 Dean Jackson 2013-01-10 18:02:50 PST 
Committed r139392: <http://trac.webkit.org/changeset/139392>