Bug 106617 - Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
Summary: Setting width overrides intrinsic min-width/max-width on flexboxes and their ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 106143 106675
  Show dependency tree / graph
 
Reported: 2013-01-10 16:38 PST by Ojan Vafai
Modified: 2013-01-11 18:22 PST (History)
10 users (show)

See Also:

Attachments
Patch (29.45 KB, patch)
2013-01-10 16:41 PST, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-10 16:38:04 PST 
Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
Comment 1 Ojan Vafai 2013-01-10 16:41:48 PST 
Created attachment 182225 [details]
Patch
Comment 2 Tony Chang 2013-01-11 13:56:25 PST 
Comment on attachment 182225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182225&action=review

> Source/WebCore/ChangeLog:9
> +        classes that override computePrefferedLogicalWidths so that RenderBox can use

Preffered -> Preferred

> Source/WebCore/rendering/RenderBox.cpp:2064
> +    if (logicalWidth.type() == FillAvailable)
> +        return logicalWidthResult;
> +
> +    if (widthType == MainOrPreferredSize && sizesLogicalWidthToFitContent(widthType))

I see, you're saying that sizesLogicalWidthToFitContent doesn't make sense for min-width or max-width, right?

I would probably have kept the != FillAvailable in the same condition, but this seems OK too.
Comment 3 Ojan Vafai 2013-01-11 18:22:51 PST 
Committed r139535: <http://trac.webkit.org/changeset/139535>