Bug 106610 - [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
Summary: [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Trivial
Assignee: Dan Beam
URL: http://trac.webkit.org/changeset/139372
Keywords:
Depends on:
Blocks: 100560
  Show dependency treegraph
 
Reported: 2013-01-10 15:15 PST by Dan Beam
Modified: 2013-01-21 00:46 PST (History)
9 users (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2013-01-11 17:12 PST, Dan Beam
no flags Details | Formatted Diff | Diff
rebase, cq+ if lgty (4.93 KB, patch)
2013-01-11 17:54 PST, Dan Beam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Beam 2013-01-10 15:15:52 PST
Essentially I need to fix all the FIXMEs I introduced here <http://trac.webkit.org/changeset/139372> by removing a public enum value when nobody's using it any more.  I left it in to keep chrome compiling.  After I switch it in chrome code (https://chromiumcodereview.appspot.com/11821020/) it wont be used anywhere as far as I know.
Comment 1 Dan Beam 2013-01-11 17:12:10 PST
Created attachment 182449 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-11 17:23:27 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Dan Beam 2013-01-11 17:54:11 PST
Created attachment 182454 [details]
rebase, cq+ if lgty
Comment 4 WebKit Review Bot 2013-01-11 23:04:43 PST
Comment on attachment 182454 [details]
rebase, cq+ if lgty

Clearing flags on attachment: 182454

Committed r139545: <http://trac.webkit.org/changeset/139545>
Comment 5 WebKit Review Bot 2013-01-11 23:04:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Dan Beam 2013-01-21 00:46:32 PST
Thanks for landing for me, Darin!