Bug 106605 – IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions

[Alec Flett]

Created attachment 182213 [details]
Patch

[Alec Flett]

Note that this won't compile against chromium until https://codereview.chromium.org/11828054 lands.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 182213 [details]
Patch

Attachment 182213 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15810065

[Peter Beverloo (cr-android ews)]

Comment on attachment 182213 [details]
Patch

Attachment 182213 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15803139

[Alec Flett]

Created attachment 182376 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182376 [details]
Patch for landing

Rejecting attachment 182376 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
pts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2
urityOrigin&, WebKit::WebFrame*, const WebKit::WebString&)
cc1plus: warnings being treated as errors
At global scope:
cc1plus: error: unrecognized command line option "-Wno-narrowing"
cc1plus: error: unrecognized command line option "-Wno-narrowing"
make: *** [out/Release/obj.target/webkit_support/Source/WebKit/chromium/webkit/support/test_webkit_platform_support.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/15801552

[Alec Flett]

sigh. I think that issue was because that build hadn't picked up the latest chromium, which fixes that. Gonna wait a bit and try again.

[WebKit Review Bot]

Comment on attachment 182376 [details]
Patch for landing

Attachment 182376 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15806474

[Peter Beverloo (cr-android ews)]

Comment on attachment 182376 [details]
Patch for landing

Attachment 182376 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15804476

[Alec Flett]

Comment on attachment 182376 [details]
Patch for landing

ok, chromium stuff that I missed before has now finally landed.

[WebKit Review Bot]

Comment on attachment 182376 [details]
Patch for landing

Rejecting attachment 182376 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
eue/Source/WebKit/chromium/third_party/libjingle/source --revision 257 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
41>At revision 257.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15853392

[Alec Flett]

Created attachment 182602 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182602 [details]
Patch for landing

Rejecting attachment 182602 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/skia/include --revision 7126 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 7126.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15867570

[Adam Barth]

Comment on attachment 182602 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=182602&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

The following ChangeLog files contain OOPS:

        trunk/Source/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.

[Alec Flett]

Created attachment 182617 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182617 [details]
Patch for landing

Clearing flags on attachment: 182617

Committed r139666: <http://trac.webkit.org/changeset/139666>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.