Bug 106604 - [chromium] Don't regenerate all bindings when any idl file changes
Summary: [chromium] Don't regenerate all bindings when any idl file changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 14:25 PST by Tony Chang
Modified: 2013-01-11 14:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2013-01-10 14:36 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2013-01-10 14:25:14 PST 
[chromium] Don't regenerate all bindings when any idl file changes
Comment 1 Tony Chang 2013-01-10 14:36:12 PST 
Created attachment 182212 [details]
Patch
Comment 2 Tony Chang 2013-01-10 14:42:33 PST 
What do you two think of this approach?  This is similar to https://bugs.webkit.org/show_bug.cgi?id=89125 but as Haraken mentions, most build systems can't generate dependencies while they are running like make can (evan says that ninja can't do this). This isn't quite as sophisticated (we still regenerate all the bindings sometimes), but not nearly as often.

I'm not sure how to do this with qmake or cmake, although Maciej's patch could be applied to the GTK+ build since it uses make.
Comment 3 Kentaro Hara 2013-01-11 00:20:06 PST 
Comment on attachment 182212 [details]
Patch

I think this is a good approach to practically solving the all-idl-files-rebuild problem. Thanks for the great patch!
Comment 4 WebKit Review Bot 2013-01-11 14:09:56 PST 
Comment on attachment 182212 [details]
Patch

Clearing flags on attachment: 182212

Committed r139494: <http://trac.webkit.org/changeset/139494>
Comment 5 WebKit Review Bot 2013-01-11 14:09:59 PST 
All reviewed patches have been landed.  Closing bug.