Bug 106591 - Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
Summary: Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 106143
  Show dependency tree / graph
 
Reported: 2013-01-10 11:59 PST by Ojan Vafai
Modified: 2013-01-10 12:33 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.75 KB, patch)
2013-01-10 12:01 PST, Ojan Vafai 		leviw: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-10 11:59:32 PST 
Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
Comment 1 Ojan Vafai 2013-01-10 12:01:18 PST 
Created attachment 182187 [details]
Patch
Comment 2 Levi Weintraub 2013-01-10 12:14:55 PST 
Comment on attachment 182187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182187&action=review

> Source/WebCore/ChangeLog:27
> +        * rendering/RenderGrid.cpp:
> +        (WebCore::RenderGrid::computePreferredLogicalWidths):

Nit: a short summary would be nice for the changes, especially calling out that you're only adding a FIXME to RenderGrid.
Comment 3 Ojan Vafai 2013-01-10 12:33:45 PST 
Committed r139351: <http://trac.webkit.org/changeset/139351>