Bug 106590 - Add Mac WK2 EWS bots
Summary: Add Mac WK2 EWS bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-10 11:49 PST by Ryosuke Niwa
Modified: 2013-01-15 18:14 PST (History)
8 users (show)

See Also:


Attachments
Adds MacWK2EWS class to earlywarningsystem.py (2.08 KB, patch)
2013-01-10 11:54 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Also update QueueStatusServer (2.54 KB, patch)
2013-01-10 12:02 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Added MacWK2Port (3.63 KB, patch)
2013-01-10 13:16 PST, Ryosuke Niwa
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-01-10 11:49:56 PST
We got more Mac minis!
Comment 1 Ryosuke Niwa 2013-01-10 11:54:22 PST
Created attachment 182183 [details]
Adds MacWK2EWS class to earlywarningsystem.py
Comment 2 Ryosuke Niwa 2013-01-10 11:55:03 PST
Comment on attachment 182183 [details]
Adds MacWK2EWS class to earlywarningsystem.py

View in context: https://bugs.webkit.org/attachment.cgi?id=182183&action=review

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:220
> +    port_name = "mac"

Do I need to make this mac-wk2 instead?
Comment 3 Ryosuke Niwa 2013-01-10 12:02:39 PST
Created attachment 182188 [details]
Also update QueueStatusServer
Comment 4 Ryosuke Niwa 2013-01-10 12:35:30 PST
Comment on attachment 182188 [details]
Also update QueueStatusServer

Missing some bits and pieces to support WK2. It appears to me that Qt EWS WK2 bots are doing exactly what Qt EWS bots do :(
Comment 5 Ryosuke Niwa 2013-01-10 13:16:08 PST
Created attachment 182196 [details]
Added MacWK2Port
Comment 6 Ryosuke Niwa 2013-01-10 13:22:28 PST
Thanks for the review!
Comment 7 Ryosuke Niwa 2013-01-10 13:29:08 PST
Committed r139357: <http://trac.webkit.org/changeset/139357>
Comment 8 Ryosuke Niwa 2013-01-10 13:29:54 PST
Also see <rdar://problem/12991857>.
Comment 9 Ryosuke Niwa 2013-01-15 18:14:08 PST
Typo fixed in http://trac.webkit.org/changeset/139818.