RESOLVED FIXED 106584
Dashboard Cleanup: Do not generate the page if we are about to reload. 
https://bugs.webkit.org/show_bug.cgi?id=106584
Summary Dashboard Cleanup: Do not generate the page if we are about to reload.
Julie Parent
Reported 2013-01-10 11:05:53 PST
Dashboard Cleanup: Do not generate the page if we are about to reload.
Attachments
Patch (2.76 KB, patch)
2013-01-10 11:09 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.01 KB, patch)
2013-01-10 11:35 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-01-10 11:09:44 PST
Created attachment 182173 [details] Patch
Dirk Pranke
Comment 2 2013-01-10 11:22:23 PST
Comment on attachment 182173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182173&action=review > Tools/TestResultServer/static-dashboards/dashboard_base.js:-330 > - return {}; can you add a comment up at line 318 indicating that the function returns whether to generate the page or not? The function name is slightly misleading since it's now parsing parameters *and* telling you whether to generate the page, but I can't think of a better function name that would capture that w/o being awkward.
Ojan Vafai
Comment 3 2013-01-10 11:23:29 PST
Comment on attachment 182173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182173&action=review > Tools/TestResultServer/static-dashboards/dashboard_base.js:353 > + shouldGeneratePage = handleQueryParameterChange(dashboardSpecificDiffState); Nit: early return here and you can get rid of the local variable.
Dirk Pranke
Comment 4 2013-01-10 11:24:36 PST
(In reply to comment #3) > (From update of attachment 182173 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182173&action=review > > > Tools/TestResultServer/static-dashboards/dashboard_base.js:353 > > + shouldGeneratePage = handleQueryParameterChange(dashboardSpecificDiffState); > > Nit: early return here and you can get rid of the local variable. I thought of that too but realized that it's not clear what the true/false indicates, and so a named variable is helpful (cf. my other comment).
Julie Parent
Comment 5 2013-01-10 11:35:22 PST
Created attachment 182179 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-01-10 11:53:56 PST
Comment on attachment 182179 [details] Patch for landing Clearing flags on attachment: 182179 Committed r139348: <http://trac.webkit.org/changeset/139348>
WebKit Review Bot
Comment 7 2013-01-10 11:53:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.