Bug 106572 – [jhbuild] Remove the "run-with-jhbuild" scripts.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

[jhbuild] Remove the "run-with-jhbuild" scripts.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 182147 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182147 [details]
Patch

Attachment 182147 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15804011

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Raphael Kubo da Costa (:rakuco)]

Created attachment 182178 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Created attachment 182207 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Created attachment 182211 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182211 [details]
Patch

Clearing flags on attachment: 182211

Committed r139431: <http://trac.webkit.org/changeset/139431>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #6)
> (From update of attachment 182211 [details])
> Clearing flags on attachment: 182211
> 
> Committed r139431: <http://trac.webkit.org/changeset/139431>

And the perl fix landed in http://trac.webkit.org/changeset/139433

[Zan Dobersek]

There's also a webkitpy unit test failure:
[609/1619] webkitpy.layout_tests.port.efl_unittest.EflPortTest.test_driver_cmd_line erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 110, in test_driver_cmd_line
      self.assertTrue(len(port.driver_cmd_line()))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 709, in driver_cmd_line
      driver = self.create_driver(0)
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 927, in create_driver
      return driver.DriverProxy(self, worker_number, self._driver_class(), pixel_tests=self.get_option('pixel_tests'), no_timeout=no_timeout)
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 514, in __init__
      self._running_drivers[self._cmd_line_as_key(pixel_tests, [])] = self._driver
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 558, in _cmd_line_as_key
      return ' '.join(self.cmd_line(pixel_tests, per_test_args))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 555, in cmd_line
      return self._driver.cmd_line(pixel_tests, per_test_args or [])
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 327, in cmd_line
      cmd = self._command_wrapper(self._port.get_option('wrapper'))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 221, in _command_wrapper
      return shlex.split(wrapper_option) if wrapper_option else []
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split
      return list(lex)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next
      token = self.get_token()
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token
      raw = self.read_token()
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token
      nextchar = self.instream.read(1)
  AttributeError: 'list' object has no attribute 'read'

[Raphael Kubo da Costa (:rakuco)]

Follow-up fixes landed in <http://trac.webkit.org/changeset/139433> and <http://trac.webkit.org/changeset/139434>.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #10)
> Follow-up fixes landed in <http://trac.webkit.org/changeset/139433> and <http://trac.webkit.org/changeset/139434>.

And <http://trac.webkit.org/changeset/139438>.

[Raphael Kubo da Costa (:rakuco)]

... And <http://trac.webkit.org/changeset/139449> :(