Bug 106572 - [jhbuild] Remove the "run-with-jhbuild" scripts.
Summary: [jhbuild] Remove the "run-with-jhbuild" scripts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 08:28 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2013-01-11 08:51 PST (History)
12 users (show)

See Also:


Attachments
Patch (10.72 KB, patch)
2013-01-10 08:28 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (11.17 KB, patch)
2013-01-10 11:28 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (11.24 KB, patch)
2013-01-10 14:22 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch (11.71 KB, patch)
2013-01-10 14:35 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2013-01-10 08:28:00 PST
[jhbuild] Remove the "run-with-jhbuild" scripts.
Comment 1 Raphael Kubo da Costa (:rakuco) 2013-01-10 08:28:56 PST
Created attachment 182147 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-10 09:08:48 PST
Comment on attachment 182147 [details]
Patch

Attachment 182147 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15804011

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 3 Raphael Kubo da Costa (:rakuco) 2013-01-10 11:28:16 PST
Created attachment 182178 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2013-01-10 14:22:58 PST
Created attachment 182207 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2013-01-10 14:35:30 PST
Created attachment 182211 [details]
Patch
Comment 6 WebKit Review Bot 2013-01-11 04:52:17 PST
Comment on attachment 182211 [details]
Patch

Clearing flags on attachment: 182211

Committed r139431: <http://trac.webkit.org/changeset/139431>
Comment 7 WebKit Review Bot 2013-01-11 04:52:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Csaba Osztrogonác 2013-01-11 05:20:13 PST
(In reply to comment #6)
> (From update of attachment 182211 [details])
> Clearing flags on attachment: 182211
> 
> Committed r139431: <http://trac.webkit.org/changeset/139431>

And the perl fix landed in http://trac.webkit.org/changeset/139433
Comment 9 Zan Dobersek 2013-01-11 05:24:01 PST
There's also a webkitpy unit test failure:
[609/1619] webkitpy.layout_tests.port.efl_unittest.EflPortTest.test_driver_cmd_line erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 110, in test_driver_cmd_line
      self.assertTrue(len(port.driver_cmd_line()))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 709, in driver_cmd_line
      driver = self.create_driver(0)
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 927, in create_driver
      return driver.DriverProxy(self, worker_number, self._driver_class(), pixel_tests=self.get_option('pixel_tests'), no_timeout=no_timeout)
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 514, in __init__
      self._running_drivers[self._cmd_line_as_key(pixel_tests, [])] = self._driver
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 558, in _cmd_line_as_key
      return ' '.join(self.cmd_line(pixel_tests, per_test_args))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 555, in cmd_line
      return self._driver.cmd_line(pixel_tests, per_test_args or [])
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 327, in cmd_line
      cmd = self._command_wrapper(self._port.get_option('wrapper'))
    File "/Volumes/Data/slave/mountainlion-release-tests-wk1/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 221, in _command_wrapper
      return shlex.split(wrapper_option) if wrapper_option else []
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split
      return list(lex)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next
      token = self.get_token()
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token
      raw = self.read_token()
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token
      nextchar = self.instream.read(1)
  AttributeError: 'list' object has no attribute 'read'
Comment 10 Raphael Kubo da Costa (:rakuco) 2013-01-11 05:30:57 PST
Follow-up fixes landed in <http://trac.webkit.org/changeset/139433> and <http://trac.webkit.org/changeset/139434>.
Comment 11 Raphael Kubo da Costa (:rakuco) 2013-01-11 06:42:53 PST
(In reply to comment #10)
> Follow-up fixes landed in <http://trac.webkit.org/changeset/139433> and <http://trac.webkit.org/changeset/139434>.

And <http://trac.webkit.org/changeset/139438>.
Comment 12 Raphael Kubo da Costa (:rakuco) 2013-01-11 08:51:24 PST
... And <http://trac.webkit.org/changeset/139449> :(