Bug 106548 - [chromium] move webpermissionclient related methods to TestRunner library
Summary: [chromium] move webpermissionclient related methods to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 03:52 PST by Dan Carney
Modified: 2013-01-10 13:04 PST (History)
7 users (show)

See Also:

Attachments
Patch (43.85 KB, patch)
2013-01-10 03:52 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Patch (42.36 KB, patch)
2013-01-10 08:13 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Patch (42.29 KB, patch)
2013-01-10 08:36 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2013-01-10 03:52:18 PST 
[chromium] move webpermissionclient related methods to TestRunner library
Comment 1 Dan Carney 2013-01-10 03:52:58 PST 
Created attachment 182108 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-10 03:56:30 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2013-01-10 05:01:11 PST 
Comment on attachment 182108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182108&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:81
> +    // the location of the layout test in the file system.

no need to put the comment here

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:65
> +    virtual WebKit::WebPermissionClient* webPermissions() { return 0; }

should be const

> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:35
> +#include "WebTestRunner.h"

not needed?

> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:42
> +    : m_delegate(delegate)

just initialize this to 0 instead of passing 0 as parameter

> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:39
> +class WebTestRunner;

not needed?

> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:69
> +

remove empty line here

> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:82
> +}

and add one here after the }

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1085
> +    return normalizeLayoutTestURLInternal(url);

instead of copying the code, can you do m_shell->normalizeLayoutTestURL(urL)?
Comment 4 Dan Carney 2013-01-10 08:13:50 PST 
Created attachment 182143 [details]
Patch
Comment 5 jochen 2013-01-10 08:23:18 PST 
Comment on attachment 182143 [details]
Patch

very nice!

View in context: https://bugs.webkit.org/attachment.cgi?id=182143&action=review

> Tools/ChangeLog:65
> +        (normalizeLayoutTestURLInternal):

please update the changelog

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:86
> +    , m_webPermissions(adoptPtr(new WebPermissions()))

nit no () required after WebPermissions
Comment 6 Dan Carney 2013-01-10 08:36:39 PST 
Created attachment 182148 [details]
Patch
Comment 7 WebKit Review Bot 2013-01-10 09:16:14 PST 
Comment on attachment 182148 [details]
Patch

Rejecting attachment 182148 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15766891
Comment 8 WebKit Review Bot 2013-01-10 13:04:16 PST 
Comment on attachment 182148 [details]
Patch

Clearing flags on attachment: 182148

Committed r139355: <http://trac.webkit.org/changeset/139355>
Comment 9 WebKit Review Bot 2013-01-10 13:04:22 PST 
All reviewed patches have been landed.  Closing bug.