Bug 106546 - Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
Summary: Web Inspector: Native Memory Instrumentation: fix instrumentation for already...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 106550
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-10 03:15 PST by Ilya Tikhonovsky
Modified: 2013-01-14 00:23 PST (History)
20 users (show)

See Also:

Attachments
Patch (19.58 KB, patch)
2013-01-10 03:21 PST, Ilya Tikhonovsky 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-01-10 03:15:37 PST 
next patch with fixes for the instrumented classes.
Comment 1 Ilya Tikhonovsky 2013-01-10 03:21:36 PST 
Created attachment 182105 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-01-10 03:41:54 PST 
landed as r139306
Comment 3 noel gordon 2013-01-10 04:14:44 PST 
Two inpector tests started crashing with this change, expected?

http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/31469

Regressions: Unexpected crashes (2)
  inspector-protocol/nmi-webaudio-leak-test.html [ Crash ]
  inspector-protocol/nmi-webaudio.html [ Crash ]
Comment 4 WebKit Review Bot 2013-01-10 04:22:08 PST 
Re-opened since this is blocked by bug 106550
Comment 5 Ilya Tikhonovsky 2013-01-14 00:23:23 PST 
Committed r139589: <http://trac.webkit.org/changeset/139589>