Bug 106532 – Converting to unittest2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim 'mithro' Ansell]

Converting to unittest2

[Tim 'mithro' Ansell]

Created attachment 182075 [details]
Patch

[WebKit Review Bot]

Attachment 182075 [details] did not pass style-queue:

Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:251:  [SCMClassTests.test_run_command_with_pipe] Instance of 'SCMClassTests' has no 'assertNotEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:302:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:302:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:304:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:304:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:308:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:308:  [SCMTest._shared_test_changed_files] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:313:  [SCMTest._shared_test_added_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:313:  [SCMTest._shared_test_added_files] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:330:  [SCMTest._shared_test_added_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:334:  [SCMTest._shared_test_added_files] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:334:  [SCMTest._shared_test_added_files] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:345:  [SCMTest._shared_test_changed_files_for_revision] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:346:  [SCMTest._shared_test_changed_files_for_revision] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:346:  [SCMTest._shared_test_changed_files_for_revision] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:347:  [SCMTest._shared_test_changed_files_for_revision] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:347:  [SCMTest._shared_test_changed_files_for_revision] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:365:  [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:365:  [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:380:  [SCMTest._shared_test_diff_for_revision] Instance of 'SCMTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:381:  [SCMTest._shared_test_diff_for_revision] Instance of 'SCMTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:382:  [SCMTest._shared_test_diff_for_revision] Instance of 'SCMTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:383:  [SCMTest._shared_test_diff_for_revision] Instance of 'SCMTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:383:  [SCMTest._shared_test_diff_for_revision] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:412:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:412:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:439:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:439:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:457:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:457:  [SCMTest._shared_test_svn_apply_git_patch] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:466:  [SCMTest._shared_test_add_recursively] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:466:  [SCMTest._shared_test_add_recursively] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:472:  [SCMTest._shared_test_delete_recursively] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:472:  [SCMTest._shared_test_delete_recursively] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:474:  [SCMTest._shared_test_delete_recursively] Instance of 'SCMTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:474:  [SCMTest._shared_test_delete_recursively] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:482:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:482:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:483:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:483:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:485:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:485:  [SCMTest._shared_test_delete_recursively_or_not] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:697:  [SVNTest.test_commit_logs] Instance of 'SVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:698:  [SVNTest.test_commit_logs] Instance of 'SVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:827:  [SVNTest.test_delete] Instance of 'SVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:832:  [SVNTest.test_delete_list] Instance of 'SVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:833:  [SVNTest.test_delete_list] Instance of 'SVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:870:  [SVNTest.do_test_diff_for_file] Instance of 'SVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:871:  [SVNTest.do_test_diff_for_file] Instance of 'SVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:949:  [GitTest.test_create_patch] Instance of 'GitTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1022:  [GitTest.test_rename_files] Instance of 'GitTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1023:  [GitTest.test_rename_files] Instance of 'GitTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1088:  [GitSVNTest.test_delete_branch] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1099:  [GitSVNTest.test_remote_merge_base] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1100:  [GitSVNTest.test_remote_merge_base] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1167:  [GitSVNTest.test_commit_with_message_working_copy_only] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1195:  [GitSVNTest.test_revisions_changing_files_with_local_commit] Instance of 'GitSVNTest' has no 'assertItemsEqual' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1205:  [GitSVNTest.test_commit_with_message] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1206:  [GitSVNTest.test_commit_with_message] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1216:  [GitSVNTest.test_commit_with_message_git_commit] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1217:  [GitSVNTest.test_commit_with_message_git_commit] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1227:  [GitSVNTest.test_commit_with_message_git_commit_range] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1228:  [GitSVNTest.test_commit_with_message_git_commit_range] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1229:  [GitSVNTest.test_commit_with_message_git_commit_range] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1236:  [GitSVNTest.test_commit_with_message_only_local_commit] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1248:  [GitSVNTest.test_commit_with_message_multiple_local_commits_and_working_copy] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1249:  [GitSVNTest.test_commit_with_message_multiple_local_commits_and_working_copy] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1265:  [GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1266:  [GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1277:  [GitSVNTest.test_commit_with_message_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1278:  [GitSVNTest.test_commit_with_message_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1290:  [GitSVNTest.test_commit_with_message_not_synced] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1291:  [GitSVNTest.test_commit_with_message_not_synced] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1292:  [GitSVNTest.test_commit_with_message_not_synced] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1323:  [GitSVNTest.test_create_patch_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1324:  [GitSVNTest.test_create_patch_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1330:  [GitSVNTest.test_create_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1331:  [GitSVNTest.test_create_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1332:  [GitSVNTest.test_create_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1341:  [GitSVNTest.test_create_patch_after_merge] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1342:  [GitSVNTest.test_create_patch_after_merge] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1348:  [GitSVNTest.test_create_patch_with_changed_files] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1362:  [GitSVNTest.test_create_patch_git_commit] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1363:  [GitSVNTest.test_create_patch_git_commit] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1369:  [GitSVNTest.test_create_patch_git_commit_range] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1370:  [GitSVNTest.test_create_patch_git_commit_range] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1371:  [GitSVNTest.test_create_patch_git_commit_range] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1377:  [GitSVNTest.test_create_patch_working_copy_only] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1378:  [GitSVNTest.test_create_patch_working_copy_only] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1384:  [GitSVNTest.test_create_patch_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1385:  [GitSVNTest.test_create_patch_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1392:  [GitSVNTest.test_create_patch_not_synced] Instance of 'GitSVNTest' has no 'assertNotRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1393:  [GitSVNTest.test_create_patch_not_synced] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1394:  [GitSVNTest.test_create_patch_not_synced] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1405:  [GitSVNTest.test_create_binary_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1406:  [GitSVNTest.test_create_binary_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1419:  [GitSVNTest.test_create_binary_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1420:  [GitSVNTest.test_create_binary_patch] Instance of 'GitSVNTest' has no 'assertRegexpMatches' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1426:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1427:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1431:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1432:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1436:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1437:  [GitSVNTest.test_changed_files_local_plus_working_copy] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1443:  [GitSVNTest.test_changed_files_git_commit] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1444:  [GitSVNTest.test_changed_files_git_commit] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1450:  [GitSVNTest.test_changed_files_git_commit_range] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1451:  [GitSVNTest.test_changed_files_git_commit_range] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1452:  [GitSVNTest.test_changed_files_git_commit_range] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1458:  [GitSVNTest.test_changed_files_working_copy_only] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1459:  [GitSVNTest.test_changed_files_working_copy_only] Instance of 'GitSVNTestFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1465:  [GitSVNTest.test_changed_files_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1466:  [GitSVNTest.test_changed_files_multiple_local_commits] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1473:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1474:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1475:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1482:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1483:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1484:  [GitSVNTest.test_changed_files_not_synced] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1502:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1503:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1504:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1508:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertNotIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1509:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1510:  [GitSVNTest.test_changed_files_upstream] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1530:  [GitSVNTest.test_delete] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1535:  [GitSVNTest.test_delete_list] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1536:  [GitSVNTest.test_delete_list] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1571:  [GitSVNTest.test_diff_for_file] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1572:  [GitSVNTest.test_diff_for_file] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1577:  [GitSVNTest.test_diff_for_file] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1578:  [GitSVNTest.test_diff_for_file] Instance of 'GitSVNTest' has no 'assertIn' member  [pylint/E1101] [5]
Total errors found: 132 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 182075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182075&action=review

This is fantastic, btw.

> Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:43
> +import unittest2 as unittest

Does this need more specific paths?  I thought you had to use thirdparty.autoinstalled.unittest2 here?  I think you may have unittest2 installed on your system?

[Eric Seidel (no email)]

Unfortunately the EWS bots don't currently run the python tests (I can explain why/show you teh bugs if you'd like).  So I'll just have to believe you that this passes. :)

[Tim 'mithro' Ansell]

(In reply to comment #3)
> (From update of attachment 182075 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182075&action=review
> 
> This is fantastic, btw.
> 
> > Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:43
> > +import unittest2 as unittest
> 
> Does this need more specific paths?  I thought you had to use thirdparty.autoinstalled.unittest2 here?  I think you may have unittest2 installed on your system?

I'm pretty sure that webkitpy/thirdparty/autoinstalled is added to the sys.path

I check that otherwise it's not installed on my system.

In [1]: import unittest2
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
/fast/chrome/src/third_party/WebKit/Tools/Scripts/<ipython-input-1-1b6ed0389b61> in <module>()
----> 1 import unittest2

ImportError: No module named unittest2

[Tim 'mithro' Ansell]

Before:
Ran 1733 tests in 38.385s
FAILED (failures=1, errors=22)

After:
Ran 1733 tests in 42.298s                    
FAILED (failures=0, errors=22)

[Eric Seidel (no email)]

Comment on attachment 182075 [details]
Patch

Who knew!  LGTM.

[WebKit Review Bot]

Comment on attachment 182075 [details]
Patch

Clearing flags on attachment: 182075

Committed r139294: <http://trac.webkit.org/changeset/139294>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.