RESOLVED FIXED 106527
Should be able to tell EWS tool cold-boot.sh what the boot screen script should be 
https://bugs.webkit.org/show_bug.cgi?id=106527
Summary Should be able to tell EWS tool cold-boot.sh what the boot screen script shou...
Alan Cutter
Reported 2013-01-09 20:40:18 PST
Currently "screen -t kr ./start-queue.sh QUEUE_TYPE BOT_ID" is the template for new bot instances. To support other variants of bot instances the screen-config should be defined in its entirety.
Attachments
Patch (13.58 KB, patch)
2013-01-10 04:19 PST, Alan Cutter 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alan Cutter
Comment 1 2013-01-10 04:19:52 PST
Created attachment 182110 [details] Patch
WebKit Review Bot
Comment 2 2013-01-10 05:02:21 PST
Comment on attachment 182110 [details] Patch Attachment 182110 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15766806 New failing tests: inspector-protocol/nmi-webaudio-leak-test.html inspector/profiler/memory-instrumentation-cached-images.html
Eric Seidel (no email)
Comment 3 2013-01-10 10:25:30 PST
Death by flaky tests!
Adam Barth
Comment 4 2013-01-10 12:36:18 PST
Comment on attachment 182110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182110&action=review > Tools/ChangeLog:10 > + Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh. > + Updated GCE bot build scripts to match. > + Unable to test scripts directly as they depend on being in the repository to work! Ideally a ChangeLog would explain the "why" behind a change rather than just the "what" you're changing. My guess is that you're making this change to support building the style-queue and the sherrifbot on Google Compute Engine, but it would be nice if you added that information here so that others can understand your change too.
WebKit Review Bot
Comment 5 2013-01-10 13:02:45 PST
Comment on attachment 182110 [details] Patch Clearing flags on attachment: 182110 Committed r139354: <http://trac.webkit.org/changeset/139354>
WebKit Review Bot
Comment 6 2013-01-10 13:02:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.