Bug 106527 - Should be able to tell EWS tool cold-boot.sh what the boot screen script should be
Summary: Should be able to tell EWS tool cold-boot.sh what the boot screen script shou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks: 106005
  Show dependency treegraph
 
Reported: 2013-01-09 20:40 PST by Alan Cutter
Modified: 2013-01-10 13:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.58 KB, patch)
2013-01-10 04:19 PST, Alan Cutter
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Cutter 2013-01-09 20:40:18 PST
Currently "screen -t kr ./start-queue.sh QUEUE_TYPE BOT_ID" is the template for new bot instances.
To support other variants of bot instances the screen-config should be defined in its entirety.
Comment 1 Alan Cutter 2013-01-10 04:19:52 PST
Created attachment 182110 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-10 05:02:21 PST
Comment on attachment 182110 [details]
Patch

Attachment 182110 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15766806

New failing tests:
inspector-protocol/nmi-webaudio-leak-test.html
inspector/profiler/memory-instrumentation-cached-images.html
Comment 3 Eric Seidel (no email) 2013-01-10 10:25:30 PST
Death by flaky tests!
Comment 4 Adam Barth 2013-01-10 12:36:18 PST
Comment on attachment 182110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182110&action=review

> Tools/ChangeLog:10
> +        Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
> +        Updated GCE bot build scripts to match.
> +        Unable to test scripts directly as they depend on being in the repository to work!

Ideally a ChangeLog would explain the "why" behind a change rather than just the "what" you're changing.  My guess is that you're making this change to support building the style-queue and the sherrifbot on Google Compute Engine, but it would be nice if you added that information here so that others can understand your change too.
Comment 5 WebKit Review Bot 2013-01-10 13:02:45 PST
Comment on attachment 182110 [details]
Patch

Clearing flags on attachment: 182110

Committed r139354: <http://trac.webkit.org/changeset/139354>
Comment 6 WebKit Review Bot 2013-01-10 13:02:49 PST
All reviewed patches have been landed.  Closing bug.