Bug 106518 - [chromium] Store scrollable layer's contents size for coordinated scrollable layers
Summary: [chromium] Store scrollable layer's contents size for coordinated scrollable ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 18:55 PST by James Robinson
Modified: 2013-01-10 16:08 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2013-01-09 18:59 PST, James Robinson 		enne: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-01-09 18:55:39 PST 
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
Comment 1 James Robinson 2013-01-09 18:59:30 PST 
Created attachment 182044 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-09 19:46:18 PST 
Comment on attachment 182044 [details]
Patch

Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15766657

New failing tests:
platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
compositing/iframes/iframe-content-flipping.html
Comment 3 James Robinson 2013-01-09 21:49:02 PST 
(In reply to comment #2)
> (From update of attachment 182044 [details])
> Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15766657
> 
> New failing tests:
> platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
> compositing/iframes/iframe-content-flipping.html

I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey.  This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145.  Will confirm on linux tomorrow.
Comment 4 James Robinson 2013-01-10 15:38:01 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 182044 [details] [details])
> > Attachment 182044 [details] [details] did not pass chromium-ews (chromium-xvfb):
> > Output: http://queues.webkit.org/results/15766657
> > 
> > New failing tests:
> > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
> > compositing/iframes/iframe-content-flipping.html
> 
> I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey.  This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145.  Will confirm on linux tomorrow.

That's exactly it.  I think this is due mostly to testRunner.display() forcing us into the composite path synchronously, I doubt this has any impact on real users.  I'll mark these as needing rebase when landing.
Comment 5 Adrienne Walker 2013-01-10 15:50:03 PST 
Comment on attachment 182044 [details]
Patch

R=me.  Thanks for investigating the test failures.
Comment 6 James Robinson 2013-01-10 16:08:40 PST 
Committed r139385: <http://trac.webkit.org/changeset/139385>