Bug 106518 – [chromium] Store scrollable layer's contents size for coordinated scrollable layers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Store scrollable layer's contents size for coordinated scrollable layers

[James Robinson]

Created attachment 182044 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182044 [details]
Patch

Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15766657

New failing tests:
platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
compositing/iframes/iframe-content-flipping.html

[James Robinson]

(In reply to comment #2)
> (From update of attachment 182044 [details])
> Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15766657
> 
> New failing tests:
> platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
> compositing/iframes/iframe-content-flipping.html

I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey.  This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145.  Will confirm on linux tomorrow.

[James Robinson]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 182044 [details] [details])
> > Attachment 182044 [details] [details] did not pass chromium-ews (chromium-xvfb):
> > Output: http://queues.webkit.org/results/15766657
> > 
> > New failing tests:
> > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html
> > compositing/iframes/iframe-content-flipping.html
> 
> I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey.  This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145.  Will confirm on linux tomorrow.

That's exactly it.  I think this is due mostly to testRunner.display() forcing us into the composite path synchronously, I doubt this has any impact on real users.  I'll mark these as needing rebase when landing.

[Adrienne Walker]

Comment on attachment 182044 [details]
Patch

R=me.  Thanks for investigating the test failures.

[James Robinson]

Committed r139385: <http://trac.webkit.org/changeset/139385>