Bug 106505 - ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
Summary: ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 103339
  Show dependency tree / graph
 
Reported: 2013-01-09 16:59 PST by Hajime Morrita
Modified: 2013-01-10 09:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (24.08 KB, patch)
2013-01-09 21:41 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (35.62 KB, patch)
2013-01-09 22:28 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (31.51 KB, patch)
2013-01-09 23:07 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-01-09 16:59:26 PST 
There is a few places where ComposedShadowTreeWalker is used directly.
They should be push behind NodeRenderingTraversal to make CSTW usage optional.
Comment 1 Hajime Morrita 2013-01-09 21:41:34 PST 
Created attachment 182060 [details]
Patch
Comment 2 Build Bot 2013-01-09 21:52:23 PST 
Comment on attachment 182060 [details]
Patch

Attachment 182060 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15762805
Comment 3 Hajime Morrita 2013-01-09 22:28:37 PST 
Created attachment 182067 [details]
Patch
Comment 4 Hajime Morrita 2013-01-09 23:07:47 PST 
Created attachment 182071 [details]
Patch
Comment 5 WebKit Review Bot 2013-01-10 09:45:28 PST 
Comment on attachment 182071 [details]
Patch

Clearing flags on attachment: 182071

Committed r139325: <http://trac.webkit.org/changeset/139325>
Comment 6 WebKit Review Bot 2013-01-10 09:45:33 PST 
All reviewed patches have been landed.  Closing bug.