Bug 106503 - Speed up supplemental dependency computation
Summary: Speed up supplemental dependency computation
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
Depends on:
Blocks: 110285
  Show dependency treegraph
Reported: 2013-01-09 16:52 PST by Tony Chang
Modified: 2013-02-19 17:43 PST (History)
7 users (show)

See Also:

Patch (31.55 KB, patch)
2013-01-09 17:07 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (31.52 KB, patch)
2013-01-10 10:06 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2013-01-09 16:52:56 PST
Speed up supplemental dependency computation
Comment 1 Tony Chang 2013-01-09 17:07:52 PST
Created attachment 182018 [details]
Comment 2 Tony Chang 2013-01-09 17:10:42 PST
I may need to fix up some of the other builds.

Note that while IDLParser.pm seems to be able to handle multiple interfaces in the same idl file, we make assumptions that there is only a single interface per file. This was true before this patch (e.g., $interfaceNameToIdlFile and $idlFileToInterfaceName assumes there is a 1-to-1 mapping between idl file and interface name).
Comment 3 WebKit Review Bot 2013-01-10 09:45:21 PST
Comment on attachment 182018 [details]

Rejecting attachment 182018 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t-queue/Source/WebKit/chromium/third_party/smhasher/src --revision 147 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 147.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15804023
Comment 4 Tony Chang 2013-01-10 10:06:29 PST
Created attachment 182163 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-01-10 10:26:31 PST
Comment on attachment 182163 [details]
Patch for landing

Clearing flags on attachment: 182163

Committed r139331: <http://trac.webkit.org/changeset/139331>
Comment 6 WebKit Review Bot 2013-01-10 10:26:35 PST
All reviewed patches have been landed.  Closing bug.