Bug 106502 - Don't drop to huge tile mode if we're only slow-scrolling because of a page overlay
Summary: Don't drop to huge tile mode if we're only slow-scrolling because of a page o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-09 16:39 PST by Tim Horton
Modified: 2013-01-09 16:52 PST (History)
6 users (show)

See Also:

Attachments
no giant tiles (1.77 KB, patch)
2013-01-09 16:42 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-09 16:39:53 PST 
We only use the MainThreadScrollingReason "ForcedOnMainThread" if we install a page overlay (didInstallPageOverlay), which clients can do arbitrarily.

We probably should still use tile-sized tiles in this case (this will also prevent us from falling into gigantic tiles for WebKit2 find-in-page, among other things).
Comment 1 Simon Fraser (smfr) 2013-01-09 16:40:17 PST 
And the web inspector.
Comment 2 Tim Horton 2013-01-09 16:42:06 PST 
Created attachment 182012 [details]
no giant tiles
Comment 3 Anders Carlsson 2013-01-09 16:45:57 PST 
Comment on attachment 182012 [details]
no giant tiles

View in context: https://bugs.webkit.org/attachment.cgi?id=182012&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:204
> -            if (scrollingCoordinator->shouldUpdateScrollLayerPositionOnMainThread())
> +            if (scrollingCoordinator->mainThreadScrollingReasons() & ~ScrollingCoordinator::ForcedOnMainThread)

I think you should explain what this does with a comment.
Comment 4 Tim Horton 2013-01-09 16:46:43 PST 
(In reply to comment #3)
> (From update of attachment 182012 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182012&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:204
> > -            if (scrollingCoordinator->shouldUpdateScrollLayerPositionOnMainThread())
> > +            if (scrollingCoordinator->mainThreadScrollingReasons() & ~ScrollingCoordinator::ForcedOnMainThread)
> 
> I think you should explain what this does with a comment.

okiedokie.
Comment 5 Tim Horton 2013-01-09 16:51:52 PST 
<rdar://problem/12959143>
Comment 6 Tim Horton 2013-01-09 16:52:00 PST 
http://trac.webkit.org/changeset/139258