Bug 106492 - Add Gregg Tavares as a committer
Summary: Add Gregg Tavares as a committer
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gregg Tavares
Depends on:
Reported: 2013-01-09 14:44 PST by Gregg Tavares
Modified: 2013-01-09 16:51 PST (History)
4 users (show)

See Also:

Patch (2.00 KB, patch)
2013-01-09 14:45 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2013-01-09 14:52 PST, Gregg Tavares
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2013-01-09 14:44:25 PST
Add Gregg Tavares as a committer
Comment 1 Gregg Tavares 2013-01-09 14:45:16 PST
Created attachment 181985 [details]
Comment 2 WebKit Review Bot 2013-01-09 14:46:26 PST
Comment on attachment 181985 [details]

Rejecting attachment 181985 [details] from commit-queue.

gman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Gregg Tavares 2013-01-09 14:52:25 PST
Created attachment 181989 [details]
Comment 4 Gregg Tavares 2013-01-09 15:14:41 PST
Committed r139247: <http://trac.webkit.org/changeset/139247>
Comment 5 Eric Seidel (no email) 2013-01-09 15:36:16 PST
Fantastic!  Welcome to the party!  Now the CQ will recognize you as a committer (once it restarts, which it does about every 2 hours).
Comment 6 Alexey Proskuryakov 2013-01-09 16:51:22 PST
Comment on attachment 181989 [details]

Such changes do not require review.