Bug 106486 - [BlackBerry] Handle the case that start/end position is out of unclipped selection region
Summary: [BlackBerry] Handle the case that start/end position is out of unclipped sele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 13:23 PST by Yongxin Dai
Modified: 2013-01-10 01:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2013-01-09 13:40 PST, Yongxin Dai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2013-01-09 13:23:14 PST 
Unclipped selection region should cover start/end position of the selection. Since we exclude hidden text when calculating unclipped selection region, the start/end position can be out of unclipped selection region if it is for hidden text. If that is the case, start/end handle will be invisible. To avoid invisible handle, we take unclipped selection region as reference rectangle in the case.
Comment 1 Yongxin Dai 2013-01-09 13:40:08 PST 
Created attachment 181977 [details]
Patch
Comment 2 Rob Buis 2013-01-10 01:13:14 PST 
Comment on attachment 181977 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-01-10 01:16:31 PST 
Comment on attachment 181977 [details]
Patch

Clearing flags on attachment: 181977

Committed r139295: <http://trac.webkit.org/changeset/139295>
Comment 4 WebKit Review Bot 2013-01-10 01:16:35 PST 
All reviewed patches have been landed.  Closing bug.